diff mbox series

[v6,1/4] soc: bcm2835: Sync xHCI reset firmware property with downstream

Message ID 20200324182812.20420-2-nsaenzjulienne@suse.de (mailing list archive)
State Superseded, archived
Headers show
Series USB: pci-quirks: Add Raspberry Pi 4 quirk | expand

Commit Message

Nicolas Saenz Julienne March 24, 2020, 6:28 p.m. UTC 
The property is needed in order to trigger VL805's firmware load. Note
that there is a gap between the property introduced and the previous
one. This is also the case downstream.

Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
---
 include/soc/bcm2835/raspberrypi-firmware.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bjorn Helgaas April 2, 2020, 6:01 p.m. UTC | #1 
On Tue, Mar 24, 2020 at 07:28:09PM +0100, Nicolas Saenz Julienne wrote:
> The property is needed in order to trigger VL805's firmware load. Note
> that there is a gap between the property introduced and the previous
> one. This is also the case downstream.

I don't know what "downstream" means, so I don't know what we're
syncing *with*.  If there's another branch or project we need to
coordinate with, is there a name or URL that would help facilitate
that?  If not, I'm not sure what value that sentence adds.

Bjorn
Florian Fainelli April 4, 2020, 8:11 p.m. UTC | #2 
On 4/2/2020 11:01 AM, Bjorn Helgaas wrote:
> On Tue, Mar 24, 2020 at 07:28:09PM +0100, Nicolas Saenz Julienne wrote:
>> The property is needed in order to trigger VL805's firmware load. Note
>> that there is a gap between the property introduced and the previous
>> one. This is also the case downstream.
> 
> I don't know what "downstream" means, so I don't know what we're
> syncing *with*.  If there's another branch or project we need to
> coordinate with, is there a name or URL that would help facilitate
> that?  If not, I'm not sure what value that sentence adds.

Downstream here means the Raspberry Pi maintained kernel whose tree can
be found here:

https://github.com/raspberrypi/linux/

Changes appear there first, and people like Nicolas and Stefan try to
get them upstream from that tree into Linus' tree.
diff mbox series

Patch

diff --git a/include/soc/bcm2835/raspberrypi-firmware.h b/include/soc/bcm2835/raspberrypi-firmware.h
index 7800e12ee042..cc9cdbc66403 100644
--- a/include/soc/bcm2835/raspberrypi-firmware.h
+++ b/include/soc/bcm2835/raspberrypi-firmware.h
@@ -90,7 +90,7 @@  enum rpi_firmware_property_tag {
 	RPI_FIRMWARE_SET_PERIPH_REG =                         0x00038045,
 	RPI_FIRMWARE_GET_POE_HAT_VAL =                        0x00030049,
 	RPI_FIRMWARE_SET_POE_HAT_VAL =                        0x00030050,
-
+	RPI_FIRMWARE_NOTIFY_XHCI_RESET =                      0x00030058,
 
 	/* Dispmanx TAGS */
 	RPI_FIRMWARE_FRAMEBUFFER_ALLOCATE =                   0x00040001,