diff mbox series

dt-bindings: PCI: intel,lgm-pcie: Fix matching on all snps,dw-pcie instances

Message ID 20200819222002.2059917-1-robh@kernel.org (mailing list archive)
State Mainlined, archived
Commit a326462cba6ae7398a5c997dddf3bea39555a825
Delegated to: Rob Herring
Headers show
Series dt-bindings: PCI: intel,lgm-pcie: Fix matching on all snps,dw-pcie instances | expand

Commit Message

Rob Herring Aug. 19, 2020, 10:20 p.m. UTC
The intel,lgm-pcie binding is matching on all snps,dw-pcie instances
which is wrong. Add a custom 'select' entry to fix this.

Fixes: e54ea45a4955 ("dt-bindings: PCI: intel: Add YAML schemas for the PCIe RC controller")
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Dilip Kota <eswara.kota@linux.intel.com>
Cc: linux-pci@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
I'll take this via the DT tree.

Rob

 Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Dilip Kota Aug. 20, 2020, 7:30 a.m. UTC | #1
On 8/20/2020 6:20 AM, Rob Herring wrote:
> The intel,lgm-pcie binding is matching on all snps,dw-pcie instances
> which is wrong. Add a custom 'select' entry to fix this.
>
> Fixes: e54ea45a4955 ("dt-bindings: PCI: intel: Add YAML schemas for the PCIe RC controller")
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Dilip Kota <eswara.kota@linux.intel.com>
> Cc: linux-pci@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> I'll take this via the DT tree.
>
> Rob
>
>   Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml b/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml
> index 64b2c64ca806..a1e2be737eec 100644
> --- a/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml
> @@ -9,6 +9,14 @@ title: PCIe RC controller on Intel Gateway SoCs
>   maintainers:
>     - Dilip Kota <eswara.kota@linux.intel.com>
>   
> +select:
> +  properties:
> +    compatible:
> +      contains:
> +        const: intel,lgm-pcie
> +  required:
> +    - compatible
> +
>   properties:
>     compatible:
>       items:

Reviewed-by: Dilip Kota <eswara.kota@linux.intel.com>

Regards,
Dilip
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml b/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml
index 64b2c64ca806..a1e2be737eec 100644
--- a/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml
@@ -9,6 +9,14 @@  title: PCIe RC controller on Intel Gateway SoCs
 maintainers:
   - Dilip Kota <eswara.kota@linux.intel.com>
 
+select:
+  properties:
+    compatible:
+      contains:
+        const: intel,lgm-pcie
+  required:
+    - compatible
+
 properties:
   compatible:
     items: