diff mbox series

[v2] PCI/ACPI: Suppress missing MCFG message

Message ID 20200908210359.569294-1-jeremy.linton@arm.com (mailing list archive)
State Accepted, archived
Delegated to: Bjorn Helgaas
Headers show
Series [v2] PCI/ACPI: Suppress missing MCFG message | expand

Commit Message

Jeremy Linton Sept. 8, 2020, 9:03 p.m. UTC
MCFG is an optional ACPI table. Given there are machines
without PCI(e) (or it is hidden) we have been receiving
queries/complaints about what this message means given
its being presented as an error.

Lets reduce the severity, the ACPI table list printed at
boot will continue to provide another way to detect when
the table is missing.

Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
---
 drivers/acpi/pci_mcfg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Hanjun Guo Sept. 9, 2020, 12:59 a.m. UTC | #1
On 2020/9/9 5:03, Jeremy Linton wrote:
> MCFG is an optional ACPI table. Given there are machines
> without PCI(e) (or it is hidden) we have been receiving
> queries/complaints about what this message means given
> its being presented as an error.
> 
> Lets reduce the severity, the ACPI table list printed at
> boot will continue to provide another way to detect when
> the table is missing.
> 
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
> ---
>   drivers/acpi/pci_mcfg.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/pci_mcfg.c b/drivers/acpi/pci_mcfg.c
> index 54b36b7ad47d..c8ef3bb5aa00 100644
> --- a/drivers/acpi/pci_mcfg.c
> +++ b/drivers/acpi/pci_mcfg.c
> @@ -280,5 +280,5 @@ void __init pci_mmcfg_late_init(void)
>   {
>   	int err = acpi_table_parse(ACPI_SIG_MCFG, pci_mcfg_parse);
>   	if (err)
> -		pr_err("Failed to parse MCFG (%d)\n", err);
> +		pr_debug("Failed to parse MCFG (%d)\n", err);
>   }
> 

Reviewed-by: Hanjun Guo <guohanjun@huawei.com>
Bjorn Helgaas Sept. 9, 2020, 2:42 p.m. UTC | #2
On Tue, Sep 08, 2020 at 04:03:59PM -0500, Jeremy Linton wrote:
> MCFG is an optional ACPI table. Given there are machines
> without PCI(e) (or it is hidden) we have been receiving
> queries/complaints about what this message means given
> its being presented as an error.
> 
> Lets reduce the severity, the ACPI table list printed at
> boot will continue to provide another way to detect when
> the table is missing.
> 
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>

Applied to pci/enumeration with Hanjun's reviewed-by, thanks!

> ---
>  drivers/acpi/pci_mcfg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/pci_mcfg.c b/drivers/acpi/pci_mcfg.c
> index 54b36b7ad47d..c8ef3bb5aa00 100644
> --- a/drivers/acpi/pci_mcfg.c
> +++ b/drivers/acpi/pci_mcfg.c
> @@ -280,5 +280,5 @@ void __init pci_mmcfg_late_init(void)
>  {
>  	int err = acpi_table_parse(ACPI_SIG_MCFG, pci_mcfg_parse);
>  	if (err)
> -		pr_err("Failed to parse MCFG (%d)\n", err);
> +		pr_debug("Failed to parse MCFG (%d)\n", err);
>  }
> -- 
> 2.25.4
>
diff mbox series

Patch

diff --git a/drivers/acpi/pci_mcfg.c b/drivers/acpi/pci_mcfg.c
index 54b36b7ad47d..c8ef3bb5aa00 100644
--- a/drivers/acpi/pci_mcfg.c
+++ b/drivers/acpi/pci_mcfg.c
@@ -280,5 +280,5 @@  void __init pci_mmcfg_late_init(void)
 {
 	int err = acpi_table_parse(ACPI_SIG_MCFG, pci_mcfg_parse);
 	if (err)
-		pr_err("Failed to parse MCFG (%d)\n", err);
+		pr_debug("Failed to parse MCFG (%d)\n", err);
 }