diff mbox series

PCI: xgene-msi: Remove redundant dev_err call in xgene_msi_probe()

Message ID 20210408124745.1108948-1-yangerkun@huawei.com (mailing list archive)
State Superseded
Headers show
Series PCI: xgene-msi: Remove redundant dev_err call in xgene_msi_probe() | expand

Commit Message

yangerkun April 8, 2021, 12:47 p.m. UTC 
From: ErKun Yang <yangerkun@huawei.com>

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Erkun Yang<yangerkun@huawei.com>
---
 drivers/pci/controller/pci-xgene-msi.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Krzysztof Wilczyński April 8, 2021, 1:02 p.m. UTC | #1 
Hi,

[...]
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.

Just to add, the devm_ioremap_resource() internally calls
__devm_ioremap_resource() which is where error checking
and handling is actually having place.

> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Erkun Yang<yangerkun@huawei.com>

A space is missing just before the e-mail port of the
"Signed-off-by", you might need to correct this.

Otherwise,

Reviewed-by: Krzysztof Wilczyński <kw@linux.com>

Krzysztof
diff mbox series

Patch

diff --git a/drivers/pci/controller/pci-xgene-msi.c b/drivers/pci/controller/pci-xgene-msi.c
index 1c34c897a7e2..369b50f626fd 100644
--- a/drivers/pci/controller/pci-xgene-msi.c
+++ b/drivers/pci/controller/pci-xgene-msi.c
@@ -451,7 +451,6 @@  static int xgene_msi_probe(struct platform_device *pdev)
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	xgene_msi->msi_regs = devm_ioremap_resource(&pdev->dev, res);
 	if (IS_ERR(xgene_msi->msi_regs)) {
-		dev_err(&pdev->dev, "no reg space\n");
 		rc = PTR_ERR(xgene_msi->msi_regs);
 		goto error;
 	}