diff mbox series

[v5,14/14] arm64: dts: apple: j274: Expose PCI node for the Ethernet MAC address

Message ID 20210929163847.2807812-15-maz@kernel.org (mailing list archive)
State Not Applicable
Delegated to: Lorenzo Pieralisi
Headers show
Series PCI: Add support for Apple M1 | expand

Commit Message

Marc Zyngier Sept. 29, 2021, 4:38 p.m. UTC
At the moment, all the Minis running Linux have the same MAC
address (00:10:18:00:00:00), which is a bit annoying.

Expose the PCI node corresponding to the Ethernet device, and
declare a 'local-mac-address' property. The bootloader will update
it (m1n1 already has the required feature). And if it doesn't, then
the default value is already present in the DT.

This relies on forcing the bus number for each port so that the
endpoints connected to them are correctly numbered (and keeps dtc
quiet).

Signed-off-by: Marc Zyngier <maz@kernel.org>
---
 arch/arm64/boot/dts/apple/t8103-j274.dts | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

Comments

Hector Martin Oct. 7, 2021, 4:03 p.m. UTC | #1
On 30/09/2021 01.38, Marc Zyngier wrote:
> At the moment, all the Minis running Linux have the same MAC
> address (00:10:18:00:00:00), which is a bit annoying.
> 
> Expose the PCI node corresponding to the Ethernet device, and
> declare a 'local-mac-address' property. The bootloader will update
> it (m1n1 already has the required feature). And if it doesn't, then
> the default value is already present in the DT.
> 
> This relies on forcing the bus number for each port so that the
> endpoints connected to them are correctly numbered (and keeps dtc
> quiet).
> 
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> ---
>   arch/arm64/boot/dts/apple/t8103-j274.dts | 23 +++++++++++++++++++++++
>   1 file changed, 23 insertions(+)
> 

Acked-by: Hector Martin <marcan@marcan.st>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/apple/t8103-j274.dts b/arch/arm64/boot/dts/apple/t8103-j274.dts
index e0f6775b9878..33a80f9501dc 100644
--- a/arch/arm64/boot/dts/apple/t8103-j274.dts
+++ b/arch/arm64/boot/dts/apple/t8103-j274.dts
@@ -17,6 +17,7 @@  / {
 
 	aliases {
 		serial0 = &serial0;
+		ethernet0 = &ethernet0;
 	};
 
 	chosen {
@@ -43,3 +44,25 @@  memory@800000000 {
 &serial0 {
 	status = "okay";
 };
+
+/*
+ * Force the bus number assignments so that we can declare some of the
+ * on-board devices and properties that are populated by the bootloader
+ * (such as MAC addresses).
+ */
+&port00 {
+	bus-range = <1 1>;
+};
+
+&port01 {
+	bus-range = <2 2>;
+};
+
+&port02 {
+	bus-range = <3 3>;
+	ethernet0: pci@0,0 {
+		reg = <0x30000 0x0 0x0 0x0 0x0>;
+		/* To be filled by the loader */
+		local-mac-address = [00 10 18 00 00 00];
+	};
+};