| Message ID | 20211007122848.3366-1-kw@linux.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | [v2] PCI: visconti: Remove surplus dev_err() when using platform_get_irq_byname() | expand |
Hi Lorenzo, [...] > Changes in v2: > Remove unused "dev" variable following removal of the dev_err() as > reported by Intel's CI bot. Apologies for causing you more work. Especially, since you already applied previous version to your "pci/dwc" branch. Krzysztof
On Thu, 7 Oct 2021 12:28:48 +0000, Krzysztof Wilczyński wrote: > There is no need to call the dev_err() function directly to print a > custom message when handling an error from either the platform_get_irq() > or platform_get_irq_byname() functions as both are going to display an > appropriate error message in case of a failure. > > This change is as per suggestions from Coccinelle, e.g., > drivers/pci/controller/dwc/pcie-visconti.c:286:2-9: line 286 is redundant because platform_get_irq() already prints an error > > [...] Applied to pci/dwc, thanks! [1/1] PCI: visconti: Remove surplus dev_err() when using platform_get_irq_byname() https://git.kernel.org/lpieralisi/pci/c/5b8402562e Thanks, Lorenzo
diff --git a/drivers/pci/controller/dwc/pcie-visconti.c b/drivers/pci/controller/dwc/pcie-visconti.c index a88eab6829bb..50f80f07e4db 100644 --- a/drivers/pci/controller/dwc/pcie-visconti.c +++ b/drivers/pci/controller/dwc/pcie-visconti.c @@ -279,13 +279,10 @@ static int visconti_add_pcie_port(struct visconti_pcie *pcie, { struct dw_pcie *pci = &pcie->pci; struct pcie_port *pp = &pci->pp; - struct device *dev = &pdev->dev; pp->irq = platform_get_irq_byname(pdev, "intr"); - if (pp->irq < 0) { - dev_err(dev, "Interrupt intr is missing"); + if (pp->irq < 0) return pp->irq; - } pp->ops = &visconti_pcie_host_ops;
There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure. This change is as per suggestions from Coccinelle, e.g., drivers/pci/controller/dwc/pcie-visconti.c:286:2-9: line 286 is redundant because platform_get_irq() already prints an error Related: https://lore.kernel.org/all/20210310131913.2802385-1-kw@linux.com/ https://lore.kernel.org/all/20200802142601.1635926-1-kw@linux.com/ Signed-off-by: Krzysztof Wilczyński <kw@linux.com> --- Changes in v2: Remove unused "dev" variable following removal of the dev_err() as reported by Intel's CI bot. drivers/pci/controller/dwc/pcie-visconti.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)