[V3,12/35] soc: ti: ti_sci_inta_msi: Allocate MSI device data on first use

Commit Message

Thomas Gleixner Dec. 10, 2021, 10:19 p.m. UTC

From: Thomas Gleixner <[e-mail]>

Allocate the MSI device data on first invocation of the allocation function.

Signed-off-by: Thomas Gleixner <[e-mail]>
Reviewed-by: Greg Kroah-Hartman <[e-mail]>
Reviewed-by: Jason Gunthorpe <[e-mail]>
Cc: Nishanth Menon <[e-mail]>
Cc: Tero Kristo <[e-mail]>
Cc: Santosh Shilimkar <[e-mail]>
Cc: [e-mail]
---
 drivers/soc/ti/ti_sci_inta_msi.c |    4 ++++
 1 file changed, 4 insertions(+)

Comments

Arnd Bergmann Dec. 11, 2021, 3:22 p.m. UTC | #1

On Fri, Dec 10, 2021 at 11:19 PM Thomas Gleixner <[e-mail]> wrote:
>
> From: Thomas Gleixner <[e-mail]>
>
> Allocate the MSI device data on first invocation of the allocation function.
>
> Signed-off-by: Thomas Gleixner <[e-mail]>
> Reviewed-by: Greg Kroah-Hartman <[e-mail]>
> Reviewed-by: Jason Gunthorpe <[e-mail]>
> Cc: Nishanth Menon <[e-mail]>
> Cc: Tero Kristo <[e-mail]>
> Cc: Santosh Shilimkar <[e-mail]>
> Cc: [e-mail]

Acked-by: Arnd Bergmann <[e-mail]>

Nishanth Menon Dec. 13, 2021, 5:56 p.m. UTC | #2

On 23:19-20211210, Thomas Gleixner wrote:
> From: Thomas Gleixner <[e-mail]>
> 
> Allocate the MSI device data on first invocation of the allocation function.
> 
> Signed-off-by: Thomas Gleixner <[e-mail]>
> Reviewed-by: Greg Kroah-Hartman <[e-mail]>
> Reviewed-by: Jason Gunthorpe <[e-mail]>
> Cc: Nishanth Menon <[e-mail]>
> Cc: Tero Kristo <[e-mail]>
> Cc: Santosh Shilimkar <[e-mail]>
> Cc: [e-mail]


Acked-by: Nishanth Menon <[e-mail]>

Patch

--- a/drivers/soc/ti/ti_sci_inta_msi.c
+++ b/drivers/soc/ti/ti_sci_inta_msi.c
@@ -120,6 +120,10 @@  int ti_sci_inta_msi_domain_alloc_irqs(st
 	if (pdev->id < 0)
 		return -ENODEV;
 
+	ret = msi_setup_device_data(dev);
+	if (ret)
+		return ret;
+
 	nvec = ti_sci_inta_msi_alloc_descs(dev, res);
 	if (nvec <= 0)
 		return nvec;