| Message ID | 20220726203401.595934-4-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | PCI: qcom: Support using the same PHY for both RC and EP | expand |
On Tue, Jul 26, 2022 at 11:34:00PM +0300, Dmitry Baryshkov wrote: > Call phy_set_mode_ext() to notify the PHY driver that the PHY is being > used in the RC mode. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Thanks, Mani > --- > drivers/pci/controller/dwc/pcie-qcom.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > index 93d75cda4b04..f85f2579c087 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom.c > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > @@ -1485,6 +1485,10 @@ static int qcom_pcie_host_init(struct dw_pcie_rp *pp) > if (ret) > return ret; > > + ret = phy_set_mode_ext(pcie->phy, PHY_MODE_PCIE, 0); > + if (ret) > + return err_deinit; > + > ret = phy_power_on(pcie->phy); > if (ret) > goto err_deinit; > -- > 2.35.1 >
On Wed, Aug 24, 2022 at 08:27:58PM +0530, Manivannan Sadhasivam wrote: > On Tue, Jul 26, 2022 at 11:34:00PM +0300, Dmitry Baryshkov wrote: > > Call phy_set_mode_ext() to notify the PHY driver that the PHY is being > > used in the RC mode. > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > Thanks, > Mani > > > --- > > drivers/pci/controller/dwc/pcie-qcom.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > > index 93d75cda4b04..f85f2579c087 100644 > > --- a/drivers/pci/controller/dwc/pcie-qcom.c > > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > > @@ -1485,6 +1485,10 @@ static int qcom_pcie_host_init(struct dw_pcie_rp *pp) > > if (ret) > > return ret; > > > > + ret = phy_set_mode_ext(pcie->phy, PHY_MODE_PCIE, 0); > > + if (ret) > > + return err_deinit; Oops... Missed this one. Should be goto err_deinit; Thanks, Mani > > + > > ret = phy_power_on(pcie->phy); > > if (ret) > > goto err_deinit; > > -- > > 2.35.1 > > > > -- > மணிவண்ணன் சதாசிவம்
diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c index 93d75cda4b04..f85f2579c087 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -1485,6 +1485,10 @@ static int qcom_pcie_host_init(struct dw_pcie_rp *pp) if (ret) return ret; + ret = phy_set_mode_ext(pcie->phy, PHY_MODE_PCIE, 0); + if (ret) + return err_deinit; + ret = phy_power_on(pcie->phy); if (ret) goto err_deinit;
Call phy_set_mode_ext() to notify the PHY driver that the PHY is being used in the RC mode. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/pci/controller/dwc/pcie-qcom.c | 4 ++++ 1 file changed, 4 insertions(+)