| Message ID | 20221113112811.22266-2-albert.zhou.50@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | add hotplug depedency info | expand |
On Sun, Nov 13, 2022 at 10:28:10PM +1100, Albert Zhou wrote: > Thunderbolt and USB4 PCI cards require the hotplug feature. This is now > recorded in the help message for HOTPLUG_PCI. Further, HOTPLUG_PCI is > defaulted to Y if USB4 is selected. > > Signed-off-by: Albert Zhou <albert.zhou.50@gmail.com> > --- > drivers/pci/hotplug/Kconfig | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/hotplug/Kconfig b/drivers/pci/hotplug/Kconfig > index 840a84bb5ee2..06cc373834f5 100644 > --- a/drivers/pci/hotplug/Kconfig > +++ b/drivers/pci/hotplug/Kconfig > @@ -6,10 +6,12 @@ > menuconfig HOTPLUG_PCI > bool "Support for PCI Hotplug" > depends on PCI && SYSFS > + default y if USB4 > help > Say Y here if you have a motherboard with a PCI Hotplug controller. > This allows you to add and remove PCI cards while the machine is > - powered up and running. > + powered up and running. Thunderbolt and USB4 PCI cards require > + Hotplug. I would not say they "require" this. PCIe is completely optional in USB4 systems and it is perfectly fine to have host controllers or add-in-cards that don't have a single PCIe adapter. Not objeting the patch, though. For Linux I guess it makes sense to have this like what you are suggesting. Just perhaps changing the wordirng ;-)
On 14/11/22 21:37, Mika Westerberg wrote: >> + default y if USB4 >> help >> Say Y here if you have a motherboard with a PCI Hotplug controller. >> This allows you to add and remove PCI cards while the machine is >> - powered up and running. >> + powered up and running. Thunderbolt and USB4 PCI cards require >> + Hotplug. > I would not say they "require" this. PCIe is completely optional in USB4 > systems and it is perfectly fine to have host controllers or > add-in-cards that don't have a single PCIe adapter. > > Not objeting the patch, though. For Linux I guess it makes sense to have > this like what you are suggesting. Just perhaps changing the wordirng >
Hi, On Tue, Nov 15, 2022 at 12:38:11PM +1100, Albert Zhou wrote: > On 14/11/22 21:37, Mika Westerberg wrote: > > > + default y if USB4 > > > help > > > Say Y here if you have a motherboard with a PCI Hotplug controller. > > > This allows you to add and remove PCI cards while the machine is > > > - powered up and running. > > > + powered up and running. Thunderbolt and USB4 PCI cards require > > > + Hotplug. > > I would not say they "require" this. PCIe is completely optional in USB4 > > systems and it is perfectly fine to have host controllers or > > add-in-cards that don't have a single PCIe adapter. > > > > Not objeting the patch, though. For Linux I guess it makes sense to have > > this like what you are suggesting. Just perhaps changing the wordirng > >
diff --git a/drivers/pci/hotplug/Kconfig b/drivers/pci/hotplug/Kconfig index 840a84bb5ee2..06cc373834f5 100644 --- a/drivers/pci/hotplug/Kconfig +++ b/drivers/pci/hotplug/Kconfig @@ -6,10 +6,12 @@ menuconfig HOTPLUG_PCI bool "Support for PCI Hotplug" depends on PCI && SYSFS + default y if USB4 help Say Y here if you have a motherboard with a PCI Hotplug controller. This allows you to add and remove PCI cards while the machine is - powered up and running. + powered up and running. Thunderbolt and USB4 PCI cards require + Hotplug. When in doubt, say N.
Thunderbolt and USB4 PCI cards require the hotplug feature. This is now recorded in the help message for HOTPLUG_PCI. Further, HOTPLUG_PCI is defaulted to Y if USB4 is selected. Signed-off-by: Albert Zhou <albert.zhou.50@gmail.com> --- drivers/pci/hotplug/Kconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)