diff mbox series

PCI: mvebu: Mark driver as BROKEN

Message ID 20230114164125.1298-1-pali@kernel.org (mailing list archive)
State Accepted
Delegated to: Krzysztof Wilczyński
Headers show
Series PCI: mvebu: Mark driver as BROKEN | expand

Commit Message

Pali Rohár Jan. 14, 2023, 4:41 p.m. UTC
People are reporting that pci-mvebu.c driver does not work with recent
mainline kernel. There are more bugs which prevents its for daily usage.
So lets mark it as broken for now, until somebody would be able to fix it
in mainline kernel.

Signed-off-by: Pali Rohár <pali@kernel.org>

---
Bjorn: I would really appreciate if you take this change and send it in
pull request for v6.2 release. There is no reason to wait more longer.


I'm periodically receiving emails that driver does not work correctly
anymore, PCIe cards are not detected or that they crashes during boot.

Some of the issues are handled in patches which are waiting on the list for
a long time and nobody cares for them. Some others needs investigation.

I'm really tired in replying to those user emails as I cannot do more in
this area. I have asked more people for help but either there were only
promises without any action for more than year or simple no direction how
to move forward or what to do with it.

So mark this driver as broken. Users would see the real current state
and hopefully will stop reporting me old or new bugs.
---
 drivers/pci/controller/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Luís Mendes Jan. 15, 2023, 10:02 p.m. UTC | #1
I don't want to interfere, however I would like to contribute my
opinion as an end user of PCI_MVEBU.
I have been using Linux on a custom built hardware with an Armada
A388, for several years, and to me the most critical component for
getting PCIe working right in Linux is the u-boot version. Although
I've stopped trying the official u-boot releases as well as the SoM
vendor u-boot versions, because I don't have much time available to
tinker with those, however the ones I have tried always failed to
bring a working PCIe environment under Linux. So I am stuck with a
u-boot based on the Marvel release 2013.01.
It was key to getting PCIe working in Linux, other than that, all
Linux kernels have worked fine and I have been using an AMD RX550 PCIe
dGPU and a DVB-T/DVB-S PCIe tuner card simultaneously, each in its own
slot, without issues for all these years.

Thanks,
Luís

On Sat, Jan 14, 2023 at 4:51 PM Pali Rohár <pali@kernel.org> wrote:
>
> People are reporting that pci-mvebu.c driver does not work with recent
> mainline kernel. There are more bugs which prevents its for daily usage.
> So lets mark it as broken for now, until somebody would be able to fix it
> in mainline kernel.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
>
> ---
> Bjorn: I would really appreciate if you take this change and send it in
> pull request for v6.2 release. There is no reason to wait more longer.
>
>
> I'm periodically receiving emails that driver does not work correctly
> anymore, PCIe cards are not detected or that they crashes during boot.
>
> Some of the issues are handled in patches which are waiting on the list for
> a long time and nobody cares for them. Some others needs investigation.
>
> I'm really tired in replying to those user emails as I cannot do more in
> this area. I have asked more people for help but either there were only
> promises without any action for more than year or simple no direction how
> to move forward or what to do with it.
>
> So mark this driver as broken. Users would see the real current state
> and hopefully will stop reporting me old or new bugs.
> ---
>  drivers/pci/controller/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> index 1569d9a3ada0..b4a4d84a358b 100644
> --- a/drivers/pci/controller/Kconfig
> +++ b/drivers/pci/controller/Kconfig
> @@ -9,6 +9,7 @@ config PCI_MVEBU
>         depends on MVEBU_MBUS
>         depends on ARM
>         depends on OF
> +       depends on BROKEN
>         select PCI_BRIDGE_EMUL
>         help
>          Add support for Marvell EBU PCIe controller. This PCIe controller
> --
> 2.20.1
>
Pali Rohár Feb. 6, 2023, 10:45 p.m. UTC | #2
On Saturday 14 January 2023 17:41:25 Pali Rohár wrote:
> People are reporting that pci-mvebu.c driver does not work with recent
> mainline kernel. There are more bugs which prevents its for daily usage.
> So lets mark it as broken for now, until somebody would be able to fix it
> in mainline kernel.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>
> 
> ---
> Bjorn: I would really appreciate if you take this change and send it in
> pull request for v6.2 release. There is no reason to wait more longer.

Ping? Any comments?

> 
> I'm periodically receiving emails that driver does not work correctly
> anymore, PCIe cards are not detected or that they crashes during boot.
> 
> Some of the issues are handled in patches which are waiting on the list for
> a long time and nobody cares for them. Some others needs investigation.
> 
> I'm really tired in replying to those user emails as I cannot do more in
> this area. I have asked more people for help but either there were only
> promises without any action for more than year or simple no direction how
> to move forward or what to do with it.
> 
> So mark this driver as broken. Users would see the real current state
> and hopefully will stop reporting me old or new bugs.
> ---
>  drivers/pci/controller/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> index 1569d9a3ada0..b4a4d84a358b 100644
> --- a/drivers/pci/controller/Kconfig
> +++ b/drivers/pci/controller/Kconfig
> @@ -9,6 +9,7 @@ config PCI_MVEBU
>  	depends on MVEBU_MBUS
>  	depends on ARM
>  	depends on OF
> +	depends on BROKEN
>  	select PCI_BRIDGE_EMUL
>  	help
>  	 Add support for Marvell EBU PCIe controller. This PCIe controller
> -- 
> 2.20.1
>
Lorenzo Pieralisi Feb. 9, 2023, 9:02 a.m. UTC | #3
On Sat, 14 Jan 2023 17:41:25 +0100, Pali Rohár wrote:
> People are reporting that pci-mvebu.c driver does not work with recent
> mainline kernel. There are more bugs which prevents its for daily usage.
> So lets mark it as broken for now, until somebody would be able to fix it
> in mainline kernel.
> 
> 

Applied to pci/controller/mvebu, thanks!

[1/1] PCI: mvebu: Mark driver as BROKEN
      https://git.kernel.org/pci/pci/c/b3574f579ece

Thanks,
Lorenzo
diff mbox series

Patch

diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
index 1569d9a3ada0..b4a4d84a358b 100644
--- a/drivers/pci/controller/Kconfig
+++ b/drivers/pci/controller/Kconfig
@@ -9,6 +9,7 @@  config PCI_MVEBU
 	depends on MVEBU_MBUS
 	depends on ARM
 	depends on OF
+	depends on BROKEN
 	select PCI_BRIDGE_EMUL
 	help
 	 Add support for Marvell EBU PCIe controller. This PCIe controller