| Message ID | 20230214121333.1837-7-shradha.t@samsung.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | Refactor Exynos PCIe driver to make it generic | expand |
On 14/02/2023 13:13, Shradha Todi wrote: > DT uses the name elbi in reg-names for application logic > registers which is a wrong nomenclature. This patch fixes > the same. > > This commit shouldn't be applied without changes > "dt-bindings: PCI: Rename the term elbi to appl" and > "PCI: samsung: Rename the term elbi to appl" Dependencies and patch ordering goes after '---', because there is no point to store it in git history. Anyway, that's an ABI break and Exynos5433 is quite stable, so without clear indication of fixed bug, we should not do this. Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org] > Sent: 16 February 2023 16:34 > To: Shradha Todi <shradha.t@samsung.com>; lpieralisi@kernel.org; > kw@linux.com; robh@kernel.org; bhelgaas@google.com; > krzysztof.kozlowski+dt@linaro.org; alim.akhtar@samsung.com; > jingoohan1@gmail.com; Sergey.Semin@baikalelectronics.ru; > lukas.bulwahn@gmail.com; hongxing.zhu@nxp.com; tglx@linutronix.de; > m.szyprowski@samsung.com; jh80.chung@samsung.co; > pankaj.dubey@samsung.com > Cc: linux-pci@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: Re: [PATCH 06/16] arm64: dts: exynos: Rename the term elbi to appl > > On 14/02/2023 13:13, Shradha Todi wrote: > > DT uses the name elbi in reg-names for application logic registers > > which is a wrong nomenclature. This patch fixes the same. > > > > This commit shouldn't be applied without changes > > "dt-bindings: PCI: Rename the term elbi to appl" and > > "PCI: samsung: Rename the term elbi to appl" > > Dependencies and patch ordering goes after '---', because there is no point > to store it in git history. > Understood will take care in next set of patches. > Anyway, that's an ABI break and Exynos5433 is quite stable, so without clear > indication of fixed bug, we should not do this. > We have strong technical reason to do so. As per DWC PCIe UM, ELBI delivers an inbound register RD/WR received by the controller to external application registers when the controller is expected to generate the PCIe completion of this register RD/WR. In this driver register space which is currently marked as ELBI, is not used for this purpose (Not sure why original author has named this set of registers as ELBI) So to keep this technically correct, it should be marked as application specific wrapper register space. We used name as "appl" taking reference from intel-gw-pcie.yaml's similar register space named as "app", whereas in nvidia,tegra194-pcie.yaml it's named "appl". So our argument is if a future Samsung manufactured SoC having DWC PCIe controller comes with support of real ELBI interface, we need to use the name elbi. We know such SoC exists but they are not yet upstreamed. Ready to adopt the best possible suggested method to make this happen but I really think the name ELBI is misleading. > > Best regards, > Krzysztof
On 02/03/2023 14:07, Shradha Todi wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org] >> Sent: 16 February 2023 16:34 >> To: Shradha Todi <shradha.t@samsung.com>; lpieralisi@kernel.org; >> kw@linux.com; robh@kernel.org; bhelgaas@google.com; >> krzysztof.kozlowski+dt@linaro.org; alim.akhtar@samsung.com; >> jingoohan1@gmail.com; Sergey.Semin@baikalelectronics.ru; >> lukas.bulwahn@gmail.com; hongxing.zhu@nxp.com; tglx@linutronix.de; >> m.szyprowski@samsung.com; jh80.chung@samsung.co; >> pankaj.dubey@samsung.com >> Cc: linux-pci@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- >> kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux- >> kernel@vger.kernel.org >> Subject: Re: [PATCH 06/16] arm64: dts: exynos: Rename the term elbi to appl >> >> On 14/02/2023 13:13, Shradha Todi wrote: >>> DT uses the name elbi in reg-names for application logic registers >>> which is a wrong nomenclature. This patch fixes the same. >>> >>> This commit shouldn't be applied without changes >>> "dt-bindings: PCI: Rename the term elbi to appl" and >>> "PCI: samsung: Rename the term elbi to appl" >> >> Dependencies and patch ordering goes after '---', because there is no point >> to store it in git history. >> > > Understood will take care in next set of patches. > >> Anyway, that's an ABI break and Exynos5433 is quite stable, so without clear >> indication of fixed bug, we should not do this. >> > > We have strong technical reason to do so. > > As per DWC PCIe UM, ELBI delivers an inbound register RD/WR received by the controller to external application registers when the controller > is expected to generate the PCIe completion of this register RD/WR. > In this driver register space which is currently marked as ELBI, is not used for this purpose (Not sure why original author has named this set of registers as ELBI) > So to keep this technically correct, it should be marked as application specific wrapper register space. > We used name as "appl" taking reference from intel-gw-pcie.yaml's similar register space named as "app", whereas in nvidia,tegra194-pcie.yaml it's named "appl". > > So our argument is if a future Samsung manufactured SoC having DWC PCIe controller comes with support of real ELBI interface, we need to use the name elbi. > We know such SoC exists but they are not yet upstreamed. > > Ready to adopt the best possible suggested method to make this happen but I really think the name ELBI is misleading. All this is rather reason for a future case. What is the problem experienced now? Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi index 5519a80576c5..96b216099594 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi @@ -1944,7 +1944,7 @@ compatible = "samsung,exynos5433-pcie"; reg = <0x15700000 0x1000>, <0x156b0000 0x1000>, <0x0c000000 0x1000>; - reg-names = "dbi", "elbi", "config"; + reg-names = "dbi", "appl", "config"; #address-cells = <3>; #size-cells = <2>; #interrupt-cells = <1>;
DT uses the name elbi in reg-names for application logic registers which is a wrong nomenclature. This patch fixes the same. This commit shouldn't be applied without changes "dt-bindings: PCI: Rename the term elbi to appl" and "PCI: samsung: Rename the term elbi to appl" Signed-off-by: Shradha Todi <shradha.t@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)