diff mbox series

PCI: mt7621: Use dev_info for PCIe no card plugged on port trace

Message ID 20230324073733.1596231-1-sergio.paracuellos@gmail.com (mailing list archive)
State Accepted
Delegated to: Lorenzo Pieralisi
Headers show
Series PCI: mt7621: Use dev_info for PCIe no card plugged on port trace | expand

Commit Message

Sergio Paracuellos March 24, 2023, 7:37 a.m. UTC
When there is no card plugged on PCIe port a trace that says the port will
be disabled appears. This is expected behaviour but currently is using
'dev_err' for doing that. Since this is not an error at all, change the
trace to use 'dev_info' instead.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
 drivers/pci/controller/pcie-mt7621.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Lorenzo Pieralisi March 24, 2023, 3:41 p.m. UTC | #1
On Fri, 24 Mar 2023 08:37:33 +0100, Sergio Paracuellos wrote:
> When there is no card plugged on PCIe port a trace that says the port will
> be disabled appears. This is expected behaviour but currently is using
> 'dev_err' for doing that. Since this is not an error at all, change the
> trace to use 'dev_info' instead.
> 
> 

Applied to controller/mt7621, thanks!

[1/1] PCI: mt7621: Use dev_info for PCIe no card plugged on port trace
      https://git.kernel.org/pci/pci/c/50233e105a03

Thanks,
Lorenzo
Sergio Paracuellos March 28, 2023, 8:16 a.m. UTC | #2
On Fri, Mar 24, 2023 at 4:41 PM Lorenzo Pieralisi <lpieralisi@kernel.org> wrote:
>
> On Fri, 24 Mar 2023 08:37:33 +0100, Sergio Paracuellos wrote:
> > When there is no card plugged on PCIe port a trace that says the port will
> > be disabled appears. This is expected behaviour but currently is using
> > 'dev_err' for doing that. Since this is not an error at all, change the
> > trace to use 'dev_info' instead.
> >
> >
>
> Applied to controller/mt7621, thanks!
>
> [1/1] PCI: mt7621: Use dev_info for PCIe no card plugged on port trace
>       https://git.kernel.org/pci/pci/c/50233e105a03
>
> Thanks,
> Lorenzo

Thanks, Lorenzo!

Best regards,
    Sergio Paracuellos
diff mbox series

Patch

diff --git a/drivers/pci/controller/pcie-mt7621.c b/drivers/pci/controller/pcie-mt7621.c
index 63a5f4463a9f..a445ec314375 100644
--- a/drivers/pci/controller/pcie-mt7621.c
+++ b/drivers/pci/controller/pcie-mt7621.c
@@ -378,8 +378,8 @@  static int mt7621_pcie_init_ports(struct mt7621_pcie *pcie)
 		u32 slot = port->slot;
 
 		if (!mt7621_pcie_port_is_linkup(port)) {
-			dev_err(dev, "pcie%d no card, disable it (RST & CLK)\n",
-				slot);
+			dev_info(dev, "pcie%d no card, disable it (RST & CLK)\n",
+				 slot);
 			mt7621_control_assert(port);
 			port->enabled = false;
 			num_disabled++;