| Message ID | 20230411033928.30397-3-Sergey.Semin@baikalelectronics.ru (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | PCI: dwc: Relatively simple fixes and cleanups | expand |
On Tue, Apr 11, 2023 at 06:39:20AM +0300, Serge Semin wrote: > The message is printed if the number of requested inbound iATU windows > exceed the device capability. In that case the message should either refer > to the "dma-ranges" DT property or to the DMA-ranges mapping. We suggest > to use the later version as a counterpart to the just CPU-ranges mapping. > In any case the current "Dma-ranges" phrase seems incorrect. > > Suggested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> - Mani > --- > drivers/pci/controller/dwc/pcie-designware-host.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c > index 9952057c8819..5718b4bb67f0 100644 > --- a/drivers/pci/controller/dwc/pcie-designware-host.c > +++ b/drivers/pci/controller/dwc/pcie-designware-host.c > @@ -723,7 +723,7 @@ static int dw_pcie_iatu_setup(struct dw_pcie_rp *pp) > } > > if (pci->num_ib_windows <= i) > - dev_warn(pci->dev, "Dma-ranges exceed inbound iATU size (%u)\n", > + dev_warn(pci->dev, "DMA-ranges exceed inbound iATU size (%u)\n", > pci->num_ib_windows); > > return 0; > -- > 2.40.0 > >
diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c index 9952057c8819..5718b4bb67f0 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -723,7 +723,7 @@ static int dw_pcie_iatu_setup(struct dw_pcie_rp *pp) } if (pci->num_ib_windows <= i) - dev_warn(pci->dev, "Dma-ranges exceed inbound iATU size (%u)\n", + dev_warn(pci->dev, "DMA-ranges exceed inbound iATU size (%u)\n", pci->num_ib_windows); return 0;
The message is printed if the number of requested inbound iATU windows exceed the device capability. In that case the message should either refer to the "dma-ranges" DT property or to the DMA-ranges mapping. We suggest to use the later version as a counterpart to the just CPU-ranges mapping. In any case the current "Dma-ranges" phrase seems incorrect. Suggested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> --- drivers/pci/controller/dwc/pcie-designware-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)