| Message ID | 20230411180302.2678736-4-terry.bowman@amd.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
| Series | None | expand |
On Tue, 11 Apr 2023 13:02:59 -0500 Terry Bowman <terry.bowman@amd.com> wrote: > The CXL driver plans to use cper_print_aer() for restricted CXL host > (RCH) logging. cper_print_aer() is not exported and as a result is not > available to the CXL driver or other loadable modules. Export > cper_print_aer() making it available to CXL and other loadable modules. > > Signed-off-by: Terry Bowman <terry.bowman@amd.com> > Cc: Mahesh J Salgaonkar <mahesh@linux.ibm.com> > Cc: "Oliver O'Halloran" <oohall@gmail.com> > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: linux-pci@vger.kernel.org Seems reasonable. FWIW Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- > drivers/pci/pcie/aer.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c > index f6c24ded134c..7a25b62d9e01 100644 > --- a/drivers/pci/pcie/aer.c > +++ b/drivers/pci/pcie/aer.c > @@ -812,6 +812,7 @@ void cper_print_aer(struct pci_dev *dev, int aer_severity, > trace_aer_event(dev_name(&dev->dev), (status & ~mask), > aer_severity, tlp_header_valid, &aer->header_log); > } > +EXPORT_SYMBOL_GPL(cper_print_aer); > #endif > > /**
Terry Bowman wrote: > The CXL driver plans to use cper_print_aer() for restricted CXL host > (RCH) logging. cper_print_aer() is not exported and as a result is not > available to the CXL driver or other loadable modules. Export > cper_print_aer() making it available to CXL and other loadable modules. > > Signed-off-by: Terry Bowman <terry.bowman@amd.com> > Cc: Mahesh J Salgaonkar <mahesh@linux.ibm.com> > Cc: "Oliver O'Halloran" <oohall@gmail.com> > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: linux-pci@vger.kernel.org > --- > drivers/pci/pcie/aer.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c > index f6c24ded134c..7a25b62d9e01 100644 > --- a/drivers/pci/pcie/aer.c > +++ b/drivers/pci/pcie/aer.c > @@ -812,6 +812,7 @@ void cper_print_aer(struct pci_dev *dev, int aer_severity, > trace_aer_event(dev_name(&dev->dev), (status & ~mask), > aer_severity, tlp_header_valid, &aer->header_log); > } > +EXPORT_SYMBOL_GPL(cper_print_aer); Same EXPORT_SYMBOL_NS_GPL() as the last patch, I can't imagine another scenario where this symbol needs exporting. Does this not need a stub in the CONFIG_PCIEAER=n case? Maybe that's handled in the CXL code, I'll keep reading...
diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index f6c24ded134c..7a25b62d9e01 100644 --- a/drivers/pci/pcie/aer.c +++ b/drivers/pci/pcie/aer.c @@ -812,6 +812,7 @@ void cper_print_aer(struct pci_dev *dev, int aer_severity, trace_aer_event(dev_name(&dev->dev), (status & ~mask), aer_severity, tlp_header_valid, &aer->header_log); } +EXPORT_SYMBOL_GPL(cper_print_aer); #endif /**
The CXL driver plans to use cper_print_aer() for restricted CXL host (RCH) logging. cper_print_aer() is not exported and as a result is not available to the CXL driver or other loadable modules. Export cper_print_aer() making it available to CXL and other loadable modules. Signed-off-by: Terry Bowman <terry.bowman@amd.com> Cc: Mahesh J Salgaonkar <mahesh@linux.ibm.com> Cc: "Oliver O'Halloran" <oohall@gmail.com> Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: linux-pci@vger.kernel.org --- drivers/pci/pcie/aer.c | 1 + 1 file changed, 1 insertion(+)