diff mbox series

[3/3] dt-bindings: PCI: rcar-gen4-pcie-ep: Fix minor issues

Message ID 20230901131711.2861283-4-yoshihiro.shimoda.uh@renesas.com (mailing list archive)
State Superseded
Delegated to: Krzysztof Wilczyński
Headers show
Series dt-bindings: PCI: Revise dwc and rcar-gen4-pcie | expand

Commit Message

Yoshihiro Shimoda Sept. 1, 2023, 1:17 p.m. UTC 
Fix minor issues of rcar-gen4-pci-ep.yaml.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---

This patch will be squashed into the following commit on the pci.git /
controller/rcar branch so that many fixes into a patch:

dt-bindings: PCI: renesas: Add R-Car Gen4 PCIe Endpoint
https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=controller/rcar&id=738bded11aaa3a9717e415197cd6b833dc439cb3
---
 .../bindings/pci/rcar-gen4-pci-ep.yaml        | 39 ++++++++++++-------
 1 file changed, 24 insertions(+), 15 deletions(-)

Comments

Geert Uytterhoeven Sept. 4, 2023, 8:44 a.m. UTC | #1 
On Sat, Sep 2, 2023 at 12:40 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> Fix minor issues of rcar-gen4-pci-ep.yaml.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
>
> This patch will be squashed into the following commit on the pci.git /
> controller/rcar branch so that many fixes into a patch:
>
> dt-bindings: PCI: renesas: Add R-Car Gen4 PCIe Endpoint
> https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=controller/rcar&id=738bded11aaa3a9717e415197cd6b833dc439cb3

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pci/rcar-gen4-pci-ep.yaml b/Documentation/devicetree/bindings/pci/rcar-gen4-pci-ep.yaml
index 4e6be856104c..fe38f62da066 100644
--- a/Documentation/devicetree/bindings/pci/rcar-gen4-pci-ep.yaml
+++ b/Documentation/devicetree/bindings/pci/rcar-gen4-pci-ep.yaml
@@ -20,7 +20,7 @@  properties:
       - const: renesas,rcar-gen4-pcie-ep  # R-Car Gen4
 
   reg:
-    maxItems: 6
+    maxItems: 7
 
   reg-names:
     items:
@@ -29,6 +29,7 @@  properties:
       - const: atu
       - const: dma
       - const: app
+      - const: phy
       - const: addr_space
 
   interrupts:
@@ -40,12 +41,6 @@  properties:
       - const: sft_ce
       - const: app
 
-  power-domains:
-    maxItems: 1
-
-  resets:
-    maxItems: 1
-
   clocks:
     maxItems: 2
 
@@ -54,8 +49,15 @@  properties:
       - const: core
       - const: ref
 
-  max-functions:
-    maximum: 2
+  power-domains:
+    maxItems: 1
+
+  resets:
+    maxItems: 1
+
+  reset-names:
+    items:
+      - const: pwr
 
   max-link-speed:
     maximum: 4
@@ -63,15 +65,20 @@  properties:
   num-lanes:
     maximum: 4
 
+  max-functions:
+    maximum: 2
+
 required:
   - compatible
   - reg
   - reg-names
   - interrupts
-  - resets
-  - power-domains
+  - interrupt-names
   - clocks
   - clock-names
+  - power-domains
+  - resets
+  - reset-names
 
 unevaluatedProperties: false
 
@@ -87,10 +94,11 @@  examples:
 
         pcie0_ep: pcie-ep@e65d0000 {
             compatible = "renesas,r8a779f0-pcie-ep", "renesas,rcar-gen4-pcie-ep";
-            reg = <0 0xe65d0000 0 0x2000>, <0 0xe65d2800 0 0x0800>,
+            reg = <0 0xe65d0000 0 0x2000>, <0 0xe65d2000 0 0x1000>,
                   <0 0xe65d3000 0 0x2000>, <0 0xe65d5000 0 0x1200>,
-                  <0 0xe65d6200 0 0x0e00>, <0 0xfe000000 0 0x400000>;
-            reg-names = "dbi", "dbi2", "atu", "dma", "app", "addr_space";
+                  <0 0xe65d6200 0 0x0e00>, <0 0xe65d7000 0 0x0400>,
+                  <0 0xfe000000 0 0x400000>;
+            reg-names = "dbi", "dbi2", "atu", "dma", "app", "phy", "addr_space";
             interrupts = <GIC_SPI 417 IRQ_TYPE_LEVEL_HIGH>,
                          <GIC_SPI 418 IRQ_TYPE_LEVEL_HIGH>,
                          <GIC_SPI 422 IRQ_TYPE_LEVEL_HIGH>;
@@ -99,8 +107,9 @@  examples:
             clock-names = "core", "ref";
             power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>;
             resets = <&cpg 624>;
-            num-lanes = <2>;
+            reset-names = "pwr";
             max-link-speed = <4>;
+            num-lanes = <2>;
             max-functions = /bits/ 8 <2>;
         };
     };