diff mbox series

[v4,1/3] cxl: Add rcd_regs to cxl_rcrb_info

Message ID 20240409073528.13214-2-kobayashi.da-06@fujitsu.com (mailing list archive)
State Superseded
Headers show
Series cxl: Export cxl1.1 device link status to sysfs | expand

Commit Message

Kobayashi,Daisuke April 9, 2024, 7:35 a.m. UTC
Add rcd regs to cxl_rcrb_info to cache the RCD register values.

Signed-off-by: "Kobayashi,Daisuke" <kobayashi.da-06@fujitsu.com>
---
 drivers/cxl/cxl.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Dave Jiang April 9, 2024, 7:08 p.m. UTC | #1
On 4/9/24 12:35 AM, Kobayashi,Daisuke wrote:
> Add rcd regs to cxl_rcrb_info to cache the RCD register values.

I suggest you squash this patch with 2/3. There's not much meaning of adding variables without showing usage.

> 
> Signed-off-by: "Kobayashi,Daisuke" <kobayashi.da-06@fujitsu.com>
> ---
>  drivers/cxl/cxl.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h
> index 003feebab79b..2dc827c301a1 100644
> --- a/drivers/cxl/cxl.h
> +++ b/drivers/cxl/cxl.h
> @@ -647,6 +647,9 @@ cxl_find_dport_by_dev(struct cxl_port *port, const struct device *dport_dev)
>  struct cxl_rcrb_info {
>  	resource_size_t base;
>  	u16 aer_cap;
> +	u16 rcd_lnkctrl;
> +	u16 rcd_lnkstatus;
> +	u32 rcd_lnkcap;
>  };
>  
>  /**
diff mbox series

Patch

diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h
index 003feebab79b..2dc827c301a1 100644
--- a/drivers/cxl/cxl.h
+++ b/drivers/cxl/cxl.h
@@ -647,6 +647,9 @@  cxl_find_dport_by_dev(struct cxl_port *port, const struct device *dport_dev)
 struct cxl_rcrb_info {
 	resource_size_t base;
 	u16 aer_cap;
+	u16 rcd_lnkctrl;
+	u16 rcd_lnkstatus;
+	u32 rcd_lnkcap;
 };
 
 /**