| Message ID | 20240422195904.3591683-2-sean.anderson@linux.dev (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Krzysztof Wilczyński |
| Headers | show |
| Series | PCI: xilinx-nwl: Add phy support | expand |
On Mon, 22 Apr 2024 15:58:58 -0400, Sean Anderson wrote: > Add phys properties so Linux can power-on/configure the GTR > transcievers. > > Signed-off-by: Sean Anderson <sean.anderson@linux.dev> > --- > > Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml: properties:phy-names: {'maxItems': 4, 'items': [{'pattern': '^pcie-phy[0-3]$'}]} should not be valid under {'required': ['maxItems']} hint: "maxItems" is not needed with an "items" list from schema $id: http://devicetree.org/meta-schemas/items.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240422195904.3591683-2-sean.anderson@linux.dev The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 4/22/24 17:28, Rob Herring wrote: > > On Mon, 22 Apr 2024 15:58:58 -0400, Sean Anderson wrote: >> Add phys properties so Linux can power-on/configure the GTR >> transcievers. >> >> Signed-off-by: Sean Anderson <sean.anderson@linux.dev> >> --- >> >> Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml: properties:phy-names: {'maxItems': 4, 'items': [{'pattern': '^pcie-phy[0-3]$'}]} should not be valid under {'required': ['maxItems']} > hint: "maxItems" is not needed with an "items" list > from schema $id: http://devicetree.org/meta-schemas/items.yaml# > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240422195904.3591683-2-sean.anderson@linux.dev > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > This warning is invalid, since I am using pattern with items. --Sean
On Mon, Apr 22, 2024 at 05:30:06PM -0400, Sean Anderson wrote: > On 4/22/24 17:28, Rob Herring wrote: > > > > On Mon, 22 Apr 2024 15:58:58 -0400, Sean Anderson wrote: > >> Add phys properties so Linux can power-on/configure the GTR > >> transcievers. > >> > >> Signed-off-by: Sean Anderson <sean.anderson@linux.dev> > >> --- > >> > >> Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml | 8 ++++++++ > >> 1 file changed, 8 insertions(+) > >> > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml: properties:phy-names: {'maxItems': 4, 'items': [{'pattern': '^pcie-phy[0-3]$'}]} should not be valid under {'required': ['maxItems']} > > hint: "maxItems" is not needed with an "items" list > > from schema $id: http://devicetree.org/meta-schemas/items.yaml# > > > > doc reference errors (make refcheckdocs): > > > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240422195904.3591683-2-sean.anderson@linux.dev > > > > The base for the series is generally the latest rc1. A different dependency > > should be noted in *this* patch. > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure 'yamllint' is installed and dt-schema is up to > > date: > > > > pip3 install dtschema --upgrade > > > > Please check and re-submit after running the above command yourself. Note > > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > > your schema. However, it must be unset to test all examples with your schema. > > > > This warning is invalid, since I am using pattern with items. It is valid. You need to make 'items' a schema not a list (i.e. drop the '-'). Rob
On Mon, Apr 22, 2024 at 03:58:58PM -0400, Sean Anderson wrote: > Add phys properties so Linux can power-on/configure the GTR > transcievers. > > Signed-off-by: Sean Anderson <sean.anderson@linux.dev> > --- > > Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml b/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml > index 426f90a47f35..02315669b831 100644 > --- a/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml > @@ -61,6 +61,14 @@ properties: > interrupt-map: > maxItems: 4 > > + phys: > + maxItems: 4 > + > + phy-names: > + maxItems: 4 > + items: > + - pattern: '^pcie-phy[0-3]$' The names here are pointless and redundant. Names are local to the device, so 'pcie' is redundant. They only refer to PHYs, so 'phy' is redundant too. All you are left with is the index of the entry. Now if PCIe can work on only lanes 2 and 3 or similar, then maybe -names becomes useful. Rob
On 4/23/24 08:44, Rob Herring wrote: > On Mon, Apr 22, 2024 at 03:58:58PM -0400, Sean Anderson wrote: >> Add phys properties so Linux can power-on/configure the GTR >> transcievers. >> >> Signed-off-by: Sean Anderson <sean.anderson@linux.dev> >> --- >> >> Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml b/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml >> index 426f90a47f35..02315669b831 100644 >> --- a/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml >> +++ b/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml >> @@ -61,6 +61,14 @@ properties: >> interrupt-map: >> maxItems: 4 >> >> + phys: >> + maxItems: 4 >> + >> + phy-names: >> + maxItems: 4 >> + items: >> + - pattern: '^pcie-phy[0-3]$' > > The names here are pointless and redundant. Names are local to the > device, so 'pcie' is redundant. They only refer to PHYs, so 'phy' is > redundant too. All you are left with is the index of the entry. > > Now if PCIe can work on only lanes 2 and 3 or similar, then maybe > -names becomes useful. OK, I'll just remove them... --Sean
Hi Sean,
kernel test robot noticed the following build warnings:
[auto build test WARNING on pci/next]
[also build test WARNING on pci/for-linus xilinx-xlnx/master robh/for-next linus/master v6.9-rc5 next-20240423]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Sean-Anderson/dt-bindings-pci-xilinx-nwl-Add-phys/20240423-040215
base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link: https://lore.kernel.org/r/20240422195904.3591683-2-sean.anderson%40linux.dev
patch subject: [PATCH 1/7] dt-bindings: pci: xilinx-nwl: Add phys
compiler: loongarch64-linux-gcc (GCC) 13.2.0
dtschema version: 2024.4
reproduce: (https://download.01.org/0day-ci/archive/20240424/202404240241.n4QeoKna-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404240241.n4QeoKna-lkp@intel.com/
dtcheck warnings: (new ones prefixed by >>)
>> Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml: properties:phy-names: {'maxItems': 4, 'items': [{'pattern': '^pcie-phy[0-3]$'}]} should not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
diff --git a/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml b/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml index 426f90a47f35..02315669b831 100644 --- a/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml @@ -61,6 +61,14 @@ properties: interrupt-map: maxItems: 4 + phys: + maxItems: 4 + + phy-names: + maxItems: 4 + items: + - pattern: '^pcie-phy[0-3]$' + power-domains: maxItems: 1
Add phys properties so Linux can power-on/configure the GTR transcievers. Signed-off-by: Sean Anderson <sean.anderson@linux.dev> --- Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml | 8 ++++++++ 1 file changed, 8 insertions(+)