| Message ID | 20240430-pci-epf-rework-v4-4-22832d0d456f@linaro.org (mailing list archive) |
|---|---|
| State | Under Review |
| Delegated to: | Krzysztof Wilczyński |
| Headers | show |
| Series | PCI: endpoint: Make host reboot handling more robust | expand |
On Tue, Apr 30, 2024 at 11:43:45AM +0530, Manivannan Sadhasivam wrote: > Bus Master Enable (BME) event that is generated by the Qcom PCIe EP > controller due to host setting the Bus Master Enable bit in the Command > register doesn't have anything to do with the PCIe link. > > Hence, drop the bogus statement. > > Suggested-by: Bjorn Helgaas <helgaas@kernel.org> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > drivers/pci/controller/dwc/pcie-qcom-ep.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c b/drivers/pci/controller/dwc/pcie-qcom-ep.c > index f6e925d434f6..dcac177b55fb 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom-ep.c > +++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c > @@ -636,7 +636,7 @@ static irqreturn_t qcom_pcie_ep_global_irq_thread(int irq, void *data) > pcie_ep->link_status = QCOM_PCIE_EP_LINK_DOWN; > pci_epc_linkdown(pci->ep.epc); > } else if (FIELD_GET(PARF_INT_ALL_BME, status)) { > - dev_dbg(dev, "Received Bus Master Enable event. Link is enabled!\n"); > + dev_dbg(dev, "Received Bus Master Enable event\n"); > pcie_ep->link_status = QCOM_PCIE_EP_LINK_ENABLED; > qcom_pcie_ep_icc_update(pcie_ep); > pci_epc_bus_master_enable_notify(pci->ep.epc); > > -- > 2.25.1 > Reviewed-by: Niklas Cassel <cassel@kernel.org>
diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c b/drivers/pci/controller/dwc/pcie-qcom-ep.c index f6e925d434f6..dcac177b55fb 100644 --- a/drivers/pci/controller/dwc/pcie-qcom-ep.c +++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c @@ -636,7 +636,7 @@ static irqreturn_t qcom_pcie_ep_global_irq_thread(int irq, void *data) pcie_ep->link_status = QCOM_PCIE_EP_LINK_DOWN; pci_epc_linkdown(pci->ep.epc); } else if (FIELD_GET(PARF_INT_ALL_BME, status)) { - dev_dbg(dev, "Received Bus Master Enable event. Link is enabled!\n"); + dev_dbg(dev, "Received Bus Master Enable event\n"); pcie_ep->link_status = QCOM_PCIE_EP_LINK_ENABLED; qcom_pcie_ep_icc_update(pcie_ep); pci_epc_bus_master_enable_notify(pci->ep.epc);
Bus Master Enable (BME) event that is generated by the Qcom PCIe EP controller due to host setting the Bus Master Enable bit in the Command register doesn't have anything to do with the PCIe link. Hence, drop the bogus statement. Suggested-by: Bjorn Helgaas <helgaas@kernel.org> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> --- drivers/pci/controller/dwc/pcie-qcom-ep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)