| Message ID | 20240506004647.770666-1-linux@treblig.org (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
| Series | x86: ce4100: Remove unused struct 'sim_reg_op' | expand |
On Mon, 6 May 2024, linux@treblig.org wrote: > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > This doesn't look like it was ever used. Don't start with "This" but spell what you're talking about out so it can be read and understood without shortlog in Subject (or looking into the code change). > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> > --- > arch/x86/pci/ce4100.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/arch/x86/pci/ce4100.c b/arch/x86/pci/ce4100.c > index 87313701f069e..f5dbd25651e0f 100644 > --- a/arch/x86/pci/ce4100.c > +++ b/arch/x86/pci/ce4100.c > @@ -35,12 +35,6 @@ struct sim_dev_reg { > struct sim_reg sim_reg; > }; > > -struct sim_reg_op { > - void (*init)(struct sim_dev_reg *reg); > - void (*read)(struct sim_dev_reg *reg, u32 value); > - void (*write)(struct sim_dev_reg *reg, u32 value); > -}; > - > #define MB (1024 * 1024) > #define KB (1024) > #define SIZE_TO_MASK(size) (~(size - 1)) >
* Ilpo Järvinen (ilpo.jarvinen@linux.intel.com) wrote: > On Mon, 6 May 2024, linux@treblig.org wrote: > > > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > > > This doesn't look like it was ever used. > > Don't start with "This" but spell what you're talking about out so it > can be read and understood without shortlog in Subject (or looking into > the code change). I'm of course happy to rework that if it helps you, although I thought the subject line was sufficient. Dave > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> > > --- > > arch/x86/pci/ce4100.c | 6 ------ > > 1 file changed, 6 deletions(-) > > > > diff --git a/arch/x86/pci/ce4100.c b/arch/x86/pci/ce4100.c > > index 87313701f069e..f5dbd25651e0f 100644 > > --- a/arch/x86/pci/ce4100.c > > +++ b/arch/x86/pci/ce4100.c > > @@ -35,12 +35,6 @@ struct sim_dev_reg { > > struct sim_reg sim_reg; > > }; > > > > -struct sim_reg_op { > > - void (*init)(struct sim_dev_reg *reg); > > - void (*read)(struct sim_dev_reg *reg, u32 value); > > - void (*write)(struct sim_dev_reg *reg, u32 value); > > -}; > > - > > #define MB (1024 * 1024) > > #define KB (1024) > > #define SIZE_TO_MASK(size) (~(size - 1)) > > > > -- > i. > >
On Mon, May 06, 2024 at 02:43:20PM +0000, Dr. David Alan Gilbert wrote: > * Ilpo Järvinen (ilpo.jarvinen@linux.intel.com) wrote: > > On Mon, 6 May 2024, linux@treblig.org wrote: > > > > > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > > > > > This doesn't look like it was ever used. > > > > Don't start with "This" but spell what you're talking about out so it > > can be read and understood without shortlog in Subject (or looking into > > the code change). > > I'm of course happy to rework that if it helps you, although > I thought the subject line was sufficient. It's a minor point, to be sure. The way I think about this is "an essay title is not part of the essay itself," so the essay (commit log) should make sense all by itself. Bjorn
* Bjorn Helgaas (helgaas@kernel.org) wrote: > On Mon, May 06, 2024 at 02:43:20PM +0000, Dr. David Alan Gilbert wrote: > > * Ilpo Järvinen (ilpo.jarvinen@linux.intel.com) wrote: > > > On Mon, 6 May 2024, linux@treblig.org wrote: > > > > > > > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > > > > > > > This doesn't look like it was ever used. > > > > > > Don't start with "This" but spell what you're talking about out so it > > > can be read and understood without shortlog in Subject (or looking into > > > the code change). > > > > I'm of course happy to rework that if it helps you, although > > I thought the subject line was sufficient. > > It's a minor point, to be sure. The way I think about this is "an > essay title is not part of the essay itself," so the essay (commit > log) should make sense all by itself. OK, modified v2 sent. Dave > Bjorn >
diff --git a/arch/x86/pci/ce4100.c b/arch/x86/pci/ce4100.c index 87313701f069e..f5dbd25651e0f 100644 --- a/arch/x86/pci/ce4100.c +++ b/arch/x86/pci/ce4100.c @@ -35,12 +35,6 @@ struct sim_dev_reg { struct sim_reg sim_reg; }; -struct sim_reg_op { - void (*init)(struct sim_dev_reg *reg); - void (*read)(struct sim_dev_reg *reg, u32 value); - void (*write)(struct sim_dev_reg *reg, u32 value); -}; - #define MB (1024 * 1024) #define KB (1024) #define SIZE_TO_MASK(size) (~(size - 1))