| Message ID | 20240701221612.2112668-1-Frank.Li@nxp.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Krzysztof Wilczyński |
| Headers | show |
| Series | [v3,1/1] dt-bindings: PCI: layerscape-pci: Fix property 'fsl,pcie-scfg' type | expand |
On Mon, Jul 1, 2024 at 4:16 PM Frank Li <Frank.Li@nxp.com> wrote: > > fsl,pcie-scfg actually need an argument when there are more than one PCIe > instances. Change it to phandle-array and use items to describe each field > means. > > Fix below warning. > > arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dtb: pcie@3400000: fsl,pcie-scfg:0: [22, 0] is too long > from schema $id: http://devicetree.org/schemas/pci/fsl,layerscape-pcie.yaml# > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > Change form v2 to v3 > - remove minItems because all dts use one argument. > Change from v1 to v2 > - update commit message. > --- > .../devicetree/bindings/pci/fsl,layerscape-pcie.yaml | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml index 793986c5af7ff..741b96defcc95 100644 --- a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml @@ -43,10 +43,15 @@ properties: - const: config fsl,pcie-scfg: - $ref: /schemas/types.yaml#/definitions/phandle + $ref: /schemas/types.yaml#/definitions/phandle-array description: A phandle to the SCFG device node. The second entry is the physical PCIe controller index starting from '0'. This is used to get SCFG PEXN registers. + items: + items: + - description: A phandle to the SCFG device node + - description: PCIe controller index starting from '0' + maxItems: 1 big-endian: $ref: /schemas/types.yaml#/definitions/flag
fsl,pcie-scfg actually need an argument when there are more than one PCIe instances. Change it to phandle-array and use items to describe each field means. Fix below warning. arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dtb: pcie@3400000: fsl,pcie-scfg:0: [22, 0] is too long from schema $id: http://devicetree.org/schemas/pci/fsl,layerscape-pcie.yaml# Signed-off-by: Frank Li <Frank.Li@nxp.com> --- Change form v2 to v3 - remove minItems because all dts use one argument. Change from v1 to v2 - update commit message. --- .../devicetree/bindings/pci/fsl,layerscape-pcie.yaml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)