diff mbox series

[2/3] PCI: Move struct pci_bus_resource into bus.c

Message ID 20241017141111.44612-2-ilpo.jarvinen@linux.intel.com (mailing list archive)
State Accepted
Commit 469c9cb941480718db52876bbdb95a7a79b34889
Headers show
Series [1/3] PCI: Remove unused PCI_SUBTRACTIVE_DECODE | expand

Commit Message

Ilpo Järvinen Oct. 17, 2024, 2:11 p.m. UTC
The struct pci_bus_resource is only used in bus.c so move it there.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
 drivers/pci/bus.c   | 12 ++++++++++++
 include/linux/pci.h | 12 ------------
 2 files changed, 12 insertions(+), 12 deletions(-)

Comments

Jonathan Cameron Oct. 18, 2024, 4 p.m. UTC | #1
On Thu, 17 Oct 2024 17:11:09 +0300
Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> wrote:

> The struct pci_bus_resource is only used in bus.c so move it there.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
LGTM
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
diff mbox series

Patch

diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c
index 9cf6d0f3ab2b..e0a2441be6d3 100644
--- a/drivers/pci/bus.c
+++ b/drivers/pci/bus.c
@@ -18,6 +18,18 @@ 
 
 #include "pci.h"
 
+/*
+ * The first PCI_BRIDGE_RESOURCE_NUM PCI bus resources (those that correspond
+ * to P2P or CardBus bridge windows) go in a table.  Additional ones (for
+ * buses below host bridges or subtractive decode bridges) go in the list.
+ * Use pci_bus_for_each_resource() to iterate through all the resources.
+ */
+
+struct pci_bus_resource {
+	struct list_head	list;
+	struct resource		*res;
+};
+
 void pci_add_resource_offset(struct list_head *resources, struct resource *res,
 			     resource_size_t offset)
 {
diff --git a/include/linux/pci.h b/include/linux/pci.h
index 6a9cf80d0d4b..5a9d849b28ef 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -626,18 +626,6 @@  void pci_set_host_bridge_release(struct pci_host_bridge *bridge,
 
 int pcibios_root_bridge_prepare(struct pci_host_bridge *bridge);
 
-/*
- * The first PCI_BRIDGE_RESOURCE_NUM PCI bus resources (those that correspond
- * to P2P or CardBus bridge windows) go in a table.  Additional ones (for
- * buses below host bridges or subtractive decode bridges) go in the list.
- * Use pci_bus_for_each_resource() to iterate through all the resources.
- */
-
-struct pci_bus_resource {
-	struct list_head	list;
-	struct resource		*res;
-};
-
 #define PCI_REGION_FLAG_MASK	0x0fU	/* These bits of resource flags tell us the PCI region flags */
 
 struct pci_bus {