| Message ID | 20241217100359.4017214-4-quic_varada@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Krzysztof Wilczyński |
| Headers | show |
| Series | Add PCIe support for Qualcomm IPQ5332 | expand |
On Tue, Dec 17, 2024 at 03:33:57PM +0530, Varadarajan Narayanan wrote: > IPQ5332 PCIe is similar to IPQ9574 except for the 'reg' bindings. > Hence use the reg bindings that could be applicable for both and > avoid adding a new binding for IPQ5332. My comment was about driver, not binding. You cannot reuse bindings. Use fallbacks. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml index bd87f6b49d68..04c519393b5a 100644 --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml @@ -165,7 +165,6 @@ allOf: enum: - qcom,pcie-ipq6018 - qcom,pcie-ipq8074-gen3 - - qcom,pcie-ipq9574 then: properties: reg: @@ -207,6 +206,7 @@ allOf: contains: enum: - qcom,pcie-sdx55 + - qcom,pcie-ipq9574 then: properties: reg:
IPQ5332 PCIe is similar to IPQ9574 except for the 'reg' bindings. Hence use the reg bindings that could be applicable for both and avoid adding a new binding for IPQ5332. Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> --- Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)