| Message ID | 20241221030011.1360947-1-khalfella@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | PCI: endpoint: Set RX DMA channel to NULL aftre freeing it | expand |
Hello Mohamed, in subject s/aftre/after/ On Fri, Dec 20, 2024 at 07:00:00PM -0800, Mohamed Khalfella wrote: > Fixed a small bug in pci-epf-test driver. When requesting TX DMA channel > fails, free already allocated RX channel and set it to NULL. > Commit messages should be written in imperative. I.e. "Fix .." instead of Fixed .." > Fixes: 8353813c88ef ("PCI: endpoint: Enable DMA tests for endpoints with DMA capabilities") > There should be no empty line between the Fixes: tag and your Signed-off-by: tag, see: https://docs.kernel.org/process/submitting-patches.html With the three comments fixed, feel free to add: Reviewed-by: Niklas Cassel <cassel@kernel.org> when sending out V2. > Signed-off-by: Mohamed Khalfella <khalfella@gmail.com> > --- > drivers/pci/endpoint/functions/pci-epf-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c > index ef6677f34116..d90c8be7371e 100644 > --- a/drivers/pci/endpoint/functions/pci-epf-test.c > +++ b/drivers/pci/endpoint/functions/pci-epf-test.c > @@ -251,7 +251,7 @@ static int pci_epf_test_init_dma_chan(struct pci_epf_test *epf_test) > > fail_back_rx: > dma_release_channel(epf_test->dma_chan_rx); > - epf_test->dma_chan_tx = NULL; > + epf_test->dma_chan_rx = NULL; > > fail_back_tx: > dma_cap_zero(mask); > -- > 2.45.2 >
diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c index ef6677f34116..d90c8be7371e 100644 --- a/drivers/pci/endpoint/functions/pci-epf-test.c +++ b/drivers/pci/endpoint/functions/pci-epf-test.c @@ -251,7 +251,7 @@ static int pci_epf_test_init_dma_chan(struct pci_epf_test *epf_test) fail_back_rx: dma_release_channel(epf_test->dma_chan_rx); - epf_test->dma_chan_tx = NULL; + epf_test->dma_chan_rx = NULL; fail_back_tx: dma_cap_zero(mask);
Fixed a small bug in pci-epf-test driver. When requesting TX DMA channel fails, free already allocated RX channel and set it to NULL. Fixes: 8353813c88ef ("PCI: endpoint: Enable DMA tests for endpoints with DMA capabilities") Signed-off-by: Mohamed Khalfella <khalfella@gmail.com> --- drivers/pci/endpoint/functions/pci-epf-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)