| Message ID | 20241223110637.3697974-3-kever.yang@rock-chips.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Krzysztof Wilczyński |
| Headers | show |
| Series | Rockchip: add Rockchip rk3576 EVB1 board | expand |
On Mon, 23 Dec 2024 19:06:32 +0800, Kever Yang wrote: > rk3576 is using dwc controller, with msi interrupt directly to gic instead > of to gic its, so > - no its suport is required and the 'msi-map' is not need anymore, > - a new 'msi' interrupt is needed. > > Signed-off-by: Kever Yang <kever.yang@rock-chips.com> > --- > > Changes in v3: > - Fix dtb check broken on rk3588 > - Update commit message > > Changes in v2: > - remove required 'msi-map' > - add interrupt name 'msi' > > .../devicetree/bindings/pci/rockchip-dw-pcie-common.yaml | 4 +++- > Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml | 4 +--- > 2 files changed, 4 insertions(+), 4 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: ./Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml:85:9: [warning] wrong indentation: expected 10 but found 8 (indentation) dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241223110637.3697974-3-kever.yang@rock-chips.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 07/01/2025 08:24, Kever Yang wrote: > Hi Rob, > > On 2024/12/23 20:30, Rob Herring (Arm) wrote: >> On Mon, 23 Dec 2024 19:06:32 +0800, Kever Yang wrote: >>> rk3576 is using dwc controller, with msi interrupt directly to gic instead >>> of to gic its, so >>> - no its suport is required and the 'msi-map' is not need anymore, >>> - a new 'msi' interrupt is needed. >>> >>> Signed-off-by: Kever Yang<kever.yang@rock-chips.com> >>> --- >>> >>> Changes in v3: >>> - Fix dtb check broken on rk3588 >>> - Update commit message >>> >>> Changes in v2: >>> - remove required 'msi-map' >>> - add interrupt name 'msi' >>> >>> .../devicetree/bindings/pci/rockchip-dw-pcie-common.yaml | 4 +++- >>> Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml | 4 +--- >>> 2 files changed, 4 insertions(+), 4 deletions(-) >>> >> My bot found errors running 'make dt_binding_check' on your patch: >> >> yamllint warnings/errors: >> ./Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml:85:9: [warning] wrong indentation: expected 10 but found 8 (indentation) > > Sorry, I'm not so good at the yaml grammar, I will fix it in next version. > > But when I run the make dt_binding_check, I can't find this warning in > my side, maybe the tool has version required? Read the full instruction (it is there on purpose, to avoid trivial questions): > > > Thanks, > - Kever >> >> dtschema/dtc warnings/errors: >> >> doc reference errors (make refcheckdocs): >> >> Seehttps://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241223110637.3697974-3-kever.yang@rock-chips.com >> >> The base for the series is generally the latest rc1. A different dependency >> should be noted in *this* patch. >> >> If you already ran 'make dt_binding_check' and didn't see the above >> error(s), then make sure 'yamllint' is installed and dt-schema is up to >> date: >> >> pip3 install dtschema --upgrade Down to here. All above is fine on your side? Best regards, Krzysztof
Hi Rob, On 2024/12/23 20:30, Rob Herring (Arm) wrote: > On Mon, 23 Dec 2024 19:06:32 +0800, Kever Yang wrote: >> rk3576 is using dwc controller, with msi interrupt directly to gic instead >> of to gic its, so >> - no its suport is required and the 'msi-map' is not need anymore, >> - a new 'msi' interrupt is needed. >> >> Signed-off-by: Kever Yang<kever.yang@rock-chips.com> >> --- >> >> Changes in v3: >> - Fix dtb check broken on rk3588 >> - Update commit message >> >> Changes in v2: >> - remove required 'msi-map' >> - add interrupt name 'msi' >> >> .../devicetree/bindings/pci/rockchip-dw-pcie-common.yaml | 4 +++- >> Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml | 4 +--- >> 2 files changed, 4 insertions(+), 4 deletions(-) >> > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml:85:9: [warning] wrong indentation: expected 10 but found 8 (indentation) Sorry, I'm not so good at the yaml grammar, I will fix it in next version. But when I run the make dt_binding_check, I can't find this warning in my side, maybe the tool has version required? Thanks, - Kever > dtschema/dtc warnings/errors: > > doc reference errors (make refcheckdocs): > > Seehttps://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241223110637.3697974-3-kever.yang@rock-chips.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > >
diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml index cc9adfc7611c..3762f3dd6de3 100644 --- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml +++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml @@ -81,7 +81,9 @@ properties: - const: msg - const: legacy - const: err - - const: dma0 + - enum: + - msi + - dma0 - const: dma1 - const: dma2 - const: dma3 diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml index 550d8a684af3..9a464731fa4a 100644 --- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml @@ -26,6 +26,7 @@ properties: - const: rockchip,rk3568-pcie - items: - enum: + - rockchip,rk3576-pcie - rockchip,rk3588-pcie - const: rockchip,rk3568-pcie @@ -71,9 +72,6 @@ properties: vpcie3v3-supply: true -required: - - msi-map - unevaluatedProperties: false examples:
rk3576 is using dwc controller, with msi interrupt directly to gic instead of to gic its, so - no its suport is required and the 'msi-map' is not need anymore, - a new 'msi' interrupt is needed. Signed-off-by: Kever Yang <kever.yang@rock-chips.com> --- Changes in v3: - Fix dtb check broken on rk3588 - Update commit message Changes in v2: - remove required 'msi-map' - add interrupt name 'msi' .../devicetree/bindings/pci/rockchip-dw-pcie-common.yaml | 4 +++- Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml | 4 +--- 2 files changed, 4 insertions(+), 4 deletions(-)