| Message ID | 20241227065253.72323-1-evepolonium@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
| Series | PCI/ERR: use panic instead pci_info for device recovery failure in PCIe | expand |
On Fri, 27 Dec 2024 12:22:53 +0530 Atharva Tiwari <evepolonium@gmail.com> wrote: > update failed in drivers/pci/pcie/err.c to > trigger a kernel panic instead of pci_info > > Thanks Rewrite message as described in submitting patches documentation. Key thing here is question of 'why?' A question was in that comment, what is your reasoning for panic being the correct choice? Jonathan > > Signed-off-by: Atharva Tiwari <evepolonium@gmail.com> > --- > drivers/pci/pcie/err.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/pcie/err.c b/drivers/pci/pcie/err.c > index 31090770fffc..2630b88564d8 100644 > --- a/drivers/pci/pcie/err.c > +++ b/drivers/pci/pcie/err.c > @@ -271,8 +271,8 @@ pci_ers_result_t pcie_do_recovery(struct pci_dev *dev, > > pci_uevent_ers(bridge, PCI_ERS_RESULT_DISCONNECT); > > - /* TODO: Should kernel panic here? */ > - pci_info(bridge, "device recovery failed\n"); > + > + panic("Kernel Panic: %s: Device recovery failed\n", pci_name(bridge)); > > return status; > }
diff --git a/drivers/pci/pcie/err.c b/drivers/pci/pcie/err.c index 31090770fffc..2630b88564d8 100644 --- a/drivers/pci/pcie/err.c +++ b/drivers/pci/pcie/err.c @@ -271,8 +271,8 @@ pci_ers_result_t pcie_do_recovery(struct pci_dev *dev, pci_uevent_ers(bridge, PCI_ERS_RESULT_DISCONNECT); - /* TODO: Should kernel panic here? */ - pci_info(bridge, "device recovery failed\n"); + + panic("Kernel Panic: %s: Device recovery failed\n", pci_name(bridge)); return status; }
update failed in drivers/pci/pcie/err.c to trigger a kernel panic instead of pci_info Thanks Signed-off-by: Atharva Tiwari <evepolonium@gmail.com> --- drivers/pci/pcie/err.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)