| Message ID | 20250106153041.55267-1-linux.amoon@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Krzysztof Wilczyński |
| Headers | show |
| Series | [linux-next,v1] PCI: rockchip: Improve error handling in clock return value | expand |
diff --git a/drivers/pci/controller/pcie-rockchip.c b/drivers/pci/controller/pcie-rockchip.c index fea867c24f75..ca6163f9d2dd 100644 --- a/drivers/pci/controller/pcie-rockchip.c +++ b/drivers/pci/controller/pcie-rockchip.c @@ -99,7 +99,8 @@ int rockchip_pcie_parse_dt(struct rockchip_pcie *rockchip) rockchip->num_clks = devm_clk_bulk_get_all(dev, &rockchip->clks); if (rockchip->num_clks < 0) - return dev_err_probe(dev, err, "failed to get clocks\n"); + return dev_err_probe(dev, rockchip->num_clks, + "failed to get clocks\n"); return 0; }
Updates the error message to include the actual return value of devm_clk_bulk_get_all, which provides more context for debugging and troubleshooting the root cause of clock retrieval failures. Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Closes: https://lore.kernel.org/r/202501040409.SUV09R80-lkp@intel.com/ Signed-off-by: Anand Moon <linux.amoon@gmail.com> --- drivers/pci/controller/pcie-rockchip.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)