| Message ID | 20250221-sar2130p-pci-v3-6-61a0fdfb75b4@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Krzysztof Wilczyński |
| Headers | show |
| Series | PCI: qcom-ep: add support for using the EP on SAR2130P and SM8450 | expand |
On Fri, Feb 21, 2025 at 05:52:04PM +0200, Dmitry Baryshkov wrote: > Enable PCIe endpoint support for the Qualcomm SAR2130P platform. It is > impossible to use fallback compatible to any other platform since > SAR2130P uses slightly different set of clocks. > Still, why do you want the compatible to be added to the driver? It shall be defined in the binding with the respective clock difference. Driver should just work with the fallback compatible. - Mani
On 22 February 2025 18:50:38 EET, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote: >On Fri, Feb 21, 2025 at 05:52:04PM +0200, Dmitry Baryshkov wrote: >> Enable PCIe endpoint support for the Qualcomm SAR2130P platform. It is >> impossible to use fallback compatible to any other platform since >> SAR2130P uses slightly different set of clocks. >> > >Still, why do you want the compatible to be added to the driver? It shall be >defined in the binding with the respective clock difference. Driver should just >work with the fallback compatible. Well, per my understanding (or according to my feeling) different set of clocks means that they are not completely compatible. An Ack from DT maintainers supports this. Moreover, if we were to declare fallback, which one would you prefer? > >- Mani >
diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c b/drivers/pci/controller/dwc/pcie-qcom-ep.c index c08f64d7a825fa5da22976c8020f96ee5faa5462..dec5675c7c9d52b77f084ae139845b488fa02d2c 100644 --- a/drivers/pci/controller/dwc/pcie-qcom-ep.c +++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c @@ -933,6 +933,7 @@ static const struct of_device_id qcom_pcie_ep_match[] = { { .compatible = "qcom,sa8775p-pcie-ep", .data = &cfg_1_34_0}, { .compatible = "qcom,sdx55-pcie-ep", }, { .compatible = "qcom,sm8450-pcie-ep", }, + { .compatible = "qcom,sar2130p-pcie-ep", }, { } }; MODULE_DEVICE_TABLE(of, qcom_pcie_ep_match);
Enable PCIe endpoint support for the Qualcomm SAR2130P platform. It is impossible to use fallback compatible to any other platform since SAR2130P uses slightly different set of clocks. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/pci/controller/dwc/pcie-qcom-ep.c | 1 + 1 file changed, 1 insertion(+)