diff mbox series

PCI: Follow-up fix for BAR hardening

Message ID 20250305075354.118331-2-phasta@kernel.org (mailing list archive)
State Accepted
Delegated to: Krzysztof Wilczyński
Headers show
Series PCI: Follow-up fix for BAR hardening | expand

Commit Message

Philipp Stanner March 5, 2025, 7:53 a.m. UTC 
Fixes a bug where variables were used before being initialized.

To be squashed into commit "PCI: Check BAR index for validity"

Signed-off-by: Philipp Stanner <phasta@kernel.org>
---
Fix for this already applied patch:
https://lore.kernel.org/all/20250304143112.104190-2-phasta@kernel.org/
---
 drivers/pci/iomap.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

Comments

Krzysztof Wilczyński March 5, 2025, 8:07 a.m. UTC | #1 
Hello,

> Fixes a bug where variables were used before being initialized.
> 
> To be squashed into commit "PCI: Check BAR index for validity"

Squashed against the existing code on the branch.  Have a look:

  https://web.git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=devres&id=ba10e5011d05f20bd71d3f765fd3a77f7577ff34

Thank you!

	Krzysztof
diff mbox series

Patch

diff --git a/drivers/pci/iomap.c b/drivers/pci/iomap.c
index 0cab82cbcc99..fe706ed946df 100644
--- a/drivers/pci/iomap.c
+++ b/drivers/pci/iomap.c
@@ -40,13 +40,14 @@  void __iomem *pci_iomap_range(struct pci_dev *dev,
 
 	if (!pci_bar_index_is_valid(bar))
 		return NULL;
-	if (len <= offset || !start)
-		return NULL;
 
 	start = pci_resource_start(dev, bar);
 	len = pci_resource_len(dev, bar);
 	flags = pci_resource_flags(dev, bar);
 
+	if (len <= offset || !start)
+		return NULL;
+
 	len -= offset;
 	start += offset;
 	if (maxlen && len > maxlen)
@@ -90,13 +91,13 @@  void __iomem *pci_iomap_wc_range(struct pci_dev *dev,
 
 	if (!pci_bar_index_is_valid(bar))
 		return NULL;
-	if (len <= offset || !start)
-		return NULL;
 
 	start = pci_resource_start(dev, bar);
 	len = pci_resource_len(dev, bar);
 	flags = pci_resource_flags(dev, bar);
 
+	if (len <= offset || !start)
+		return NULL;
 	if (flags & IORESOURCE_IO)
 		return NULL;