| Message ID | 20250407145546.270683-3-herve.codina@bootlin.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | lan966x pci device: Add support for SFPs | expand |
On Mon, Apr 07, 2025 at 04:55:31PM +0200, Herve Codina wrote: > get_dev_from_fwnode() calls get_device() and so it acquires a reference > on the device returned. > > In order to be more obvious that this wrapper is a get_device() variant, > rename it to get_device_from_fwnode(). +1 to the change. Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
On Mon, Apr 7, 2025 at 7:56 AM Herve Codina <herve.codina@bootlin.com> wrote: > > get_dev_from_fwnode() calls get_device() and so it acquires a reference > on the device returned. > > In order to be more obvious that this wrapper is a get_device() variant, > rename it to get_device_from_fwnode(). > > Suggested-by: Mark Brown <broonie@kernel.org> > Link: https://lore.kernel.org/lkml/CAGETcx97QjnjVR8Z5g0ndLHpK96hLd4aYSV=iEkKPNbNOccYmA@mail.gmail.com/ > Signed-off-by: Herve Codina <herve.codina@bootlin.com> Thank you! Reviewed-by: Saravana Kannan <saravanak@google.com> > --- > drivers/base/core.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/base/core.c b/drivers/base/core.c > index d2f9d3a59d6b..f30260fd3031 100644 > --- a/drivers/base/core.c > +++ b/drivers/base/core.c > @@ -1881,7 +1881,7 @@ static void fw_devlink_unblock_consumers(struct device *dev) > device_links_write_unlock(); > } > > -#define get_dev_from_fwnode(fwnode) get_device((fwnode)->dev) > +#define get_device_from_fwnode(fwnode) get_device((fwnode)->dev) > > static bool fwnode_init_without_drv(struct fwnode_handle *fwnode) > { > @@ -1891,7 +1891,7 @@ static bool fwnode_init_without_drv(struct fwnode_handle *fwnode) > if (!(fwnode->flags & FWNODE_FLAG_INITIALIZED)) > return false; > > - dev = get_dev_from_fwnode(fwnode); > + dev = get_device_from_fwnode(fwnode); > ret = !dev || dev->links.status == DL_DEV_NO_DRIVER; > put_device(dev); > > @@ -1960,7 +1960,7 @@ static struct device *fwnode_get_next_parent_dev(const struct fwnode_handle *fwn > struct device *dev; > > fwnode_for_each_parent_node(fwnode, parent) { > - dev = get_dev_from_fwnode(parent); > + dev = get_device_from_fwnode(parent); > if (dev) { > fwnode_handle_put(parent); > return dev; > @@ -2016,8 +2016,8 @@ static bool __fw_devlink_relax_cycles(struct fwnode_handle *con_handle, > goto out; > } > > - sup_dev = get_dev_from_fwnode(sup_handle); > - con_dev = get_dev_from_fwnode(con_handle); > + sup_dev = get_device_from_fwnode(sup_handle); > + con_dev = get_device_from_fwnode(con_handle); > /* > * If sup_dev is bound to a driver and @con hasn't started binding to a > * driver, sup_dev can't be a consumer of @con. So, no need to check > @@ -2156,7 +2156,7 @@ static int fw_devlink_create_devlink(struct device *con, > if (sup_handle->flags & FWNODE_FLAG_NOT_DEVICE) > sup_dev = fwnode_get_next_parent_dev(sup_handle); > else > - sup_dev = get_dev_from_fwnode(sup_handle); > + sup_dev = get_device_from_fwnode(sup_handle); > > if (sup_dev) { > /* > @@ -2225,7 +2225,7 @@ static void __fw_devlink_link_to_consumers(struct device *dev) > bool own_link = true; > int ret; > > - con_dev = get_dev_from_fwnode(link->consumer); > + con_dev = get_device_from_fwnode(link->consumer); > /* > * If consumer device is not available yet, make a "proxy" > * SYNC_STATE_ONLY link from the consumer's parent device to > -- > 2.49.0 >
diff --git a/drivers/base/core.c b/drivers/base/core.c index d2f9d3a59d6b..f30260fd3031 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -1881,7 +1881,7 @@ static void fw_devlink_unblock_consumers(struct device *dev) device_links_write_unlock(); } -#define get_dev_from_fwnode(fwnode) get_device((fwnode)->dev) +#define get_device_from_fwnode(fwnode) get_device((fwnode)->dev) static bool fwnode_init_without_drv(struct fwnode_handle *fwnode) { @@ -1891,7 +1891,7 @@ static bool fwnode_init_without_drv(struct fwnode_handle *fwnode) if (!(fwnode->flags & FWNODE_FLAG_INITIALIZED)) return false; - dev = get_dev_from_fwnode(fwnode); + dev = get_device_from_fwnode(fwnode); ret = !dev || dev->links.status == DL_DEV_NO_DRIVER; put_device(dev); @@ -1960,7 +1960,7 @@ static struct device *fwnode_get_next_parent_dev(const struct fwnode_handle *fwn struct device *dev; fwnode_for_each_parent_node(fwnode, parent) { - dev = get_dev_from_fwnode(parent); + dev = get_device_from_fwnode(parent); if (dev) { fwnode_handle_put(parent); return dev; @@ -2016,8 +2016,8 @@ static bool __fw_devlink_relax_cycles(struct fwnode_handle *con_handle, goto out; } - sup_dev = get_dev_from_fwnode(sup_handle); - con_dev = get_dev_from_fwnode(con_handle); + sup_dev = get_device_from_fwnode(sup_handle); + con_dev = get_device_from_fwnode(con_handle); /* * If sup_dev is bound to a driver and @con hasn't started binding to a * driver, sup_dev can't be a consumer of @con. So, no need to check @@ -2156,7 +2156,7 @@ static int fw_devlink_create_devlink(struct device *con, if (sup_handle->flags & FWNODE_FLAG_NOT_DEVICE) sup_dev = fwnode_get_next_parent_dev(sup_handle); else - sup_dev = get_dev_from_fwnode(sup_handle); + sup_dev = get_device_from_fwnode(sup_handle); if (sup_dev) { /* @@ -2225,7 +2225,7 @@ static void __fw_devlink_link_to_consumers(struct device *dev) bool own_link = true; int ret; - con_dev = get_dev_from_fwnode(link->consumer); + con_dev = get_device_from_fwnode(link->consumer); /* * If consumer device is not available yet, make a "proxy" * SYNC_STATE_ONLY link from the consumer's parent device to
get_dev_from_fwnode() calls get_device() and so it acquires a reference on the device returned. In order to be more obvious that this wrapper is a get_device() variant, rename it to get_device_from_fwnode(). Suggested-by: Mark Brown <broonie@kernel.org> Link: https://lore.kernel.org/lkml/CAGETcx97QjnjVR8Z5g0ndLHpK96hLd4aYSV=iEkKPNbNOccYmA@mail.gmail.com/ Signed-off-by: Herve Codina <herve.codina@bootlin.com> --- drivers/base/core.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)