diff mbox series

[2/2] PCI: Remove pci_enable_device_io()

Message ID 213ebf62-53a3-42b7-8518-ecd5cd6d6b08@gmail.com (mailing list archive)
State Accepted
Commit fdd3f7a8ef57af55c1c8859703ffd17dcad5329b
Headers show
Series PCI: Remove pci_enable_device_io() | expand

Commit Message

Heiner Kallweit March 23, 2024, 5:16 p.m. UTC 
After the last user was removed, remove this PCI core function.
It's very unlikely that we'll see a new device requiring
io space access, even though memory space access is supported.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/pci/pci.c   | 14 --------------
 include/linux/pci.h |  1 -
 2 files changed, 15 deletions(-)

Comments

Damien Le Moal March 25, 2024, 7:58 a.m. UTC | #1 
On 3/24/24 02:16, Heiner Kallweit wrote:
> After the last user was removed, remove this PCI core function.
> It's very unlikely that we'll see a new device requiring
> io space access, even though memory space access is supported.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Looks OK to me.

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
diff mbox series

Patch

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index e5f243dd4..a26d00bf1 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -2110,20 +2110,6 @@  static int pci_enable_device_flags(struct pci_dev *dev, unsigned long flags)
 	return err;
 }
 
-/**
- * pci_enable_device_io - Initialize a device for use with IO space
- * @dev: PCI device to be initialized
- *
- * Initialize device before it's used by a driver. Ask low-level code
- * to enable I/O resources. Wake up the device if it was suspended.
- * Beware, this function can fail.
- */
-int pci_enable_device_io(struct pci_dev *dev)
-{
-	return pci_enable_device_flags(dev, IORESOURCE_IO);
-}
-EXPORT_SYMBOL(pci_enable_device_io);
-
 /**
  * pci_enable_device_mem - Initialize a device for use with Memory space
  * @dev: PCI device to be initialized
diff --git a/include/linux/pci.h b/include/linux/pci.h
index 16493426a..ba1275778 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -1315,7 +1315,6 @@  int pci_user_write_config_word(struct pci_dev *dev, int where, u16 val);
 int pci_user_write_config_dword(struct pci_dev *dev, int where, u32 val);
 
 int __must_check pci_enable_device(struct pci_dev *dev);
-int __must_check pci_enable_device_io(struct pci_dev *dev);
 int __must_check pci_enable_device_mem(struct pci_dev *dev);
 int __must_check pci_reenable_device(struct pci_dev *);
 int __must_check pcim_enable_device(struct pci_dev *pdev);