diff mbox series

[2/2] Add better warnings about invalid VPD data

Message ID 73ce2e075b909881b6396cacefeb2746f38ef618.camel@exaion.com (mailing list archive)
State Changes Requested
Delegated to: Bjorn Helgaas
Headers show
Series [1/2] Revert "PCI/VPD: Allow access to valid parts of VPD if some is invalid" | expand

Commit Message

Josselin Mouette March 8, 2024, 7:54 a.m. UTC 
Some Mellanox Connect-X 3 cards have firmware bugs which return
unfinished VPD data. This change helps to diagnose such issues
with clear warning messages.
---
 drivers/pci/vpd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/pci/vpd.c b/drivers/pci/vpd.c
index daaa208c9d9c..fc38a611dd3e 100644
--- a/drivers/pci/vpd.c
+++ b/drivers/pci/vpd.c
@@ -87,10 +87,11 @@  static size_t pci_vpd_size(struct pci_dev *dev)
 				return off;
 		}
 	}
+	pci_warn(dev, "missing VPD_STIN_END at offset %zu\n", off + 1);
 	return PCI_VPD_SZ_INVALID;
 
 error:
-	pci_info(dev, "invalid VPD tag %#04x (size %zu) at offset %zu%s\n",
+	pci_warn(dev, "invalid VPD tag %#04x (size %zu) at offset %zu%s\n",
 		 header[0], size, off, off == 0 ?
 		 "; assume missing optional EEPROM" : "");
 	return PCI_VPD_SZ_INVALID;