diff mbox series

PCI: rcar: pcie-rcar-ep: Remove unneeded includes

Message ID 7c708841a2bf84f85b14a963271c3e99c8ba38a5.1633090444.git.geert+renesas@glider.be (mailing list archive)
State Accepted
Delegated to: Lorenzo Pieralisi
Headers show
Series PCI: rcar: pcie-rcar-ep: Remove unneeded includes | expand

Commit Message

Geert Uytterhoeven Oct. 1, 2021, 12:16 p.m. UTC
Remove includes that are not needed, to speed up (re)compilation.
Include <linux/pm_runtime.h>, which is needed, and was included
implicitly through <linux/phy/phy.h> before.

Most of these are relics from splitting the driver in a host and a
common part, and adding endpoint support.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/pci/controller/pcie-rcar-ep.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Niklas Söderlund Oct. 2, 2021, 12:53 a.m. UTC | #1
Hello Geert,

Thanks for your work.

On 2021-10-01 14:16:09 +0200, Geert Uytterhoeven wrote:
> Remove includes that are not needed, to speed up (re)compilation.
> Include <linux/pm_runtime.h>, which is needed, and was included
> implicitly through <linux/phy/phy.h> before.
> 
> Most of these are relics from splitting the driver in a host and a
> common part, and adding endpoint support.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> ---
>  drivers/pci/controller/pcie-rcar-ep.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/pci/controller/pcie-rcar-ep.c b/drivers/pci/controller/pcie-rcar-ep.c
> index aa1cf24a5a723d5f..f9682df1da61929b 100644
> --- a/drivers/pci/controller/pcie-rcar-ep.c
> +++ b/drivers/pci/controller/pcie-rcar-ep.c
> @@ -6,16 +6,13 @@
>   * Author: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>   */
>  
> -#include <linux/clk.h>
>  #include <linux/delay.h>
>  #include <linux/of_address.h>
> -#include <linux/of_irq.h>
> -#include <linux/of_pci.h>
>  #include <linux/of_platform.h>
>  #include <linux/pci.h>
>  #include <linux/pci-epc.h>
> -#include <linux/phy/phy.h>
>  #include <linux/platform_device.h>
> +#include <linux/pm_runtime.h>
>  
>  #include "pcie-rcar.h"
>  
> -- 
> 2.25.1
>
Lorenzo Pieralisi Oct. 5, 2021, 9:02 a.m. UTC | #2
On Fri, 1 Oct 2021 14:16:09 +0200, Geert Uytterhoeven wrote:
> Remove includes that are not needed, to speed up (re)compilation.
> Include <linux/pm_runtime.h>, which is needed, and was included
> implicitly through <linux/phy/phy.h> before.
> 
> Most of these are relics from splitting the driver in a host and a
> common part, and adding endpoint support.
> 
> [...]

Applied to pci/rcar, thanks!

[1/1] PCI: rcar: pcie-rcar-ep: Remove unneeded includes
      https://git.kernel.org/lpieralisi/pci/c/ea52bd3459

Thanks,
Lorenzo
diff mbox series

Patch

diff --git a/drivers/pci/controller/pcie-rcar-ep.c b/drivers/pci/controller/pcie-rcar-ep.c
index aa1cf24a5a723d5f..f9682df1da61929b 100644
--- a/drivers/pci/controller/pcie-rcar-ep.c
+++ b/drivers/pci/controller/pcie-rcar-ep.c
@@ -6,16 +6,13 @@ 
  * Author: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
  */
 
-#include <linux/clk.h>
 #include <linux/delay.h>
 #include <linux/of_address.h>
-#include <linux/of_irq.h>
-#include <linux/of_pci.h>
 #include <linux/of_platform.h>
 #include <linux/pci.h>
 #include <linux/pci-epc.h>
-#include <linux/phy/phy.h>
 #include <linux/platform_device.h>
+#include <linux/pm_runtime.h>
 
 #include "pcie-rcar.h"