diff mbox

pci: endpoint: fix endpoint test build error

Message ID 89a5b4f8-69bb-a5bc-5400-06c24050595d@infradead.org (mailing list archive)
State New, archived
Delegated to: Bjorn Helgaas
Headers show

Commit Message

Randy Dunlap June 12, 2017, 2:10 a.m. UTC
From: Randy Dunlap <rdunlap@infradead.org>

PCI endpoint test driver uses crc32_le() so it should select
CRC32. Fixes this build error (when CRC32=m):

  drivers/built-in.o: In function `pci_epf_test_cmd_handler':
  pci-epf-test.c:(.text+0x2d98d): undefined reference to `crc32_le'

Fixes 349e7a85b25f (PCI: endpoint: functions: Add an EP function to test PCI).

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
---
 drivers/pci/endpoint/functions/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Comments

Kishon Vijay Abraham I June 12, 2017, 8:29 a.m. UTC | #1
On Monday 12 June 2017 07:40 AM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> PCI endpoint test driver uses crc32_le() so it should select
> CRC32. Fixes this build error (when CRC32=m):
> 
>   drivers/built-in.o: In function `pci_epf_test_cmd_handler':
>   pci-epf-test.c:(.text+0x2d98d): undefined reference to `crc32_le'
> 
> Fixes 349e7a85b25f (PCI: endpoint: functions: Add an EP function to test PCI).
> 
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>

Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  drivers/pci/endpoint/functions/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- lnx-412-rc4.orig/drivers/pci/endpoint/functions/Kconfig
> +++ lnx-412-rc4/drivers/pci/endpoint/functions/Kconfig
> @@ -5,6 +5,7 @@
>  config PCI_EPF_TEST
>  	tristate "PCI Endpoint Test driver"
>  	depends on PCI_ENDPOINT
> +	select CRC32
>  	help
>  	   Enable this configuration option to enable the test driver
>  	   for PCI Endpoint.
> 
>
Bjorn Helgaas June 12, 2017, 8:48 p.m. UTC | #2
On Sun, Jun 11, 2017 at 07:10:38PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> PCI endpoint test driver uses crc32_le() so it should select
> CRC32. Fixes this build error (when CRC32=m):
> 
>   drivers/built-in.o: In function `pci_epf_test_cmd_handler':
>   pci-epf-test.c:(.text+0x2d98d): undefined reference to `crc32_le'
> 
> Fixes 349e7a85b25f (PCI: endpoint: functions: Add an EP function to test PCI).
> 
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Applied with Kishon's ack to for-linus for v4.12 (since 349e7a85b25f first
appeared in v4.12-rc1), thanks!

> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> ---
>  drivers/pci/endpoint/functions/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- lnx-412-rc4.orig/drivers/pci/endpoint/functions/Kconfig
> +++ lnx-412-rc4/drivers/pci/endpoint/functions/Kconfig
> @@ -5,6 +5,7 @@
>  config PCI_EPF_TEST
>  	tristate "PCI Endpoint Test driver"
>  	depends on PCI_ENDPOINT
> +	select CRC32
>  	help
>  	   Enable this configuration option to enable the test driver
>  	   for PCI Endpoint.
> 
>
diff mbox

Patch

--- lnx-412-rc4.orig/drivers/pci/endpoint/functions/Kconfig
+++ lnx-412-rc4/drivers/pci/endpoint/functions/Kconfig
@@ -5,6 +5,7 @@ 
 config PCI_EPF_TEST
 	tristate "PCI Endpoint Test driver"
 	depends on PCI_ENDPOINT
+	select CRC32
 	help
 	   Enable this configuration option to enable the test driver
 	   for PCI Endpoint.