[v2] PCI: cadence: Add missing return in cdns_plat_pcie_probe()

Commit Message

Li Chen Oct. 21, 2021, 2:50 a.m. UTC

When cdns_plat_pcie_probe() succeeds, return success instead of
falling into the error handling code.

Signed-off-by: Xuliang Zhang <[e-mail]>
Reviewed-by: Bjorn Helgaas <[e-mail]>
Fixes: bd22885aa188 ("PCI: cadence: Refactor driver to use as a core library")
Cc: [e-mail]
Signed-off-by: Li Chen <[e-mail]>
---
 drivers/pci/controller/cadence/pcie-cadence-plat.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Tom Joseph Oct. 21, 2021, 10:18 a.m. UTC | #1

Hi Li,

 Thanks a lot for the patch!!

> -----Original Message-----
> From: Li Chen <[e-mail]>
> Sent: 21 October 2021 03:50
> Subject: [PATCH v2] PCI: cadence: Add missing return in
> cdns_plat_pcie_probe()
> 
> When cdns_plat_pcie_probe() succeeds, return success instead of
> falling into the error handling code.
> 
> Signed-off-by: Xuliang Zhang <[e-mail]>
> Reviewed-by: Bjorn Helgaas <[e-mail]>
> Fixes: bd22885aa188 ("PCI: cadence: Refactor driver to use as a core library")
> Cc: [e-mail]
> Signed-off-by: Li Chen <[e-mail]>
> ---
>  drivers/pci/controller/cadence/pcie-cadence-plat.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
Acked-by: Tom Joseph <[e-mail]>

Bjorn Helgaas Nov. 3, 2021, 6:51 p.m. UTC | #2

On Thu, Oct 21, 2021 at 02:50:19AM +0000, Li Chen wrote:
> When cdns_plat_pcie_probe() succeeds, return success instead of
> falling into the error handling code.
> 
> Signed-off-by: Xuliang Zhang <[e-mail]>
> Reviewed-by: Bjorn Helgaas <[e-mail]>
> Fixes: bd22885aa188 ("PCI: cadence: Refactor driver to use as a core library")
> Cc: [e-mail]
> Signed-off-by: Li Chen <[e-mail]>

This would ordinarily go via Lorenzo's tree, but I picked it up so it
would make v5.16.

> ---
>  drivers/pci/controller/cadence/pcie-cadence-plat.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/pci/controller/cadence/pcie-cadence-plat.c b/drivers/pci/controller/cadence/pcie-cadence-plat.c
> index 5fee0f89ab59..a224afadbcc0 100644
> --- a/drivers/pci/controller/cadence/pcie-cadence-plat.c
> +++ b/drivers/pci/controller/cadence/pcie-cadence-plat.c
> @@ -127,6 +127,8 @@ static int cdns_plat_pcie_probe(struct platform_device *pdev)
>  			goto err_init;
>  	}
>  
> +	return 0;
> +
>   err_init:
>   err_get_sync:
>  	pm_runtime_put_sync(dev);
> -- 
> 2.33.0
> 
> **********************************************************************
> This email and attachments contain Ambarella Proprietary and/or Confidential Information and is intended solely for the use of the individual(s) to whom it is addressed. Any unauthorized review, use, disclosure, distribute, copy, or print is prohibited. If you are not an intended recipient, please contact the sender by reply email and destroy all copies of the original message. Thank you.

Patch

diff --git a/drivers/pci/controller/cadence/pcie-cadence-plat.c b/drivers/pci/controller/cadence/pcie-cadence-plat.c
index 5fee0f89ab59..a224afadbcc0 100644
--- a/drivers/pci/controller/cadence/pcie-cadence-plat.c
+++ b/drivers/pci/controller/cadence/pcie-cadence-plat.c
@@ -127,6 +127,8 @@  static int cdns_plat_pcie_probe(struct platform_device *pdev)
 			goto err_init;
 	}
 
+	return 0;
+
  err_init:
  err_get_sync:
 	pm_runtime_put_sync(dev);