mbox series

[v2,0/2] phy: qcom-qmp-usb: fix initialization of PCS_USB

Message ID 20230828152353.16529-1-athierry@redhat.com
Headers show
Series phy: qcom-qmp-usb: fix initialization of PCS_USB | expand

Message

Adrien Thierry Aug. 28, 2023, 3:23 p.m. UTC 
This series attempts at making sure PCS_USB registers are properly
initialized. I tested it on the sa8775p. AFAICT there's no noticeable
change before/after the patch series: lsusb and dmesg output are the same.
USB is still working properly. I don't know what those PCS_USB registers
do exactly on the qmp PHY and I don't have access to the PHY datasheet, so
it's hard for me to tell the impact of them being initialized vs not.

v1 -> v2:
- Don't fallback to pcs for PCS_USB initialization (Dmitry Baryshkov)

Adrien Thierry (2):
  phy: qcom-qmp-usb: initialize PCS_USB registers
  phy: qcom-qmp-usb: split PCS_USB init table for sc8280xp and sa8775p

 drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 24 +++++++++++++++++++-----
 1 file changed, 19 insertions(+), 5 deletions(-)

Comments

Adrien Thierry Sept. 14, 2023, 8:48 p.m. UTC | #1 
Gentle ping for this series, is there still anything preventing it from
being merged?

Best,
Adrien

On Mon, Aug 28, 2023 at 11:23:49AM -0400, Adrien Thierry wrote:
> This series attempts at making sure PCS_USB registers are properly
> initialized. I tested it on the sa8775p. AFAICT there's no noticeable
> change before/after the patch series: lsusb and dmesg output are the same.
> USB is still working properly. I don't know what those PCS_USB registers
> do exactly on the qmp PHY and I don't have access to the PHY datasheet, so
> it's hard for me to tell the impact of them being initialized vs not.
> 
> v1 -> v2:
> - Don't fallback to pcs for PCS_USB initialization (Dmitry Baryshkov)
> 
> Adrien Thierry (2):
>   phy: qcom-qmp-usb: initialize PCS_USB registers
>   phy: qcom-qmp-usb: split PCS_USB init table for sc8280xp and sa8775p
> 
>  drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 24 +++++++++++++++++++-----
>  1 file changed, 19 insertions(+), 5 deletions(-)
> 
> -- 
> 2.41.0
> 
> 
> -- 
> linux-phy mailing list
> linux-phy@lists.infradead.org
> https://lists.infradead.org/mailman/listinfo/linux-phy
Vinod Koul Sept. 21, 2023, 2:26 p.m. UTC | #2 
On Mon, 28 Aug 2023 11:23:49 -0400, Adrien Thierry wrote:
> This series attempts at making sure PCS_USB registers are properly
> initialized. I tested it on the sa8775p. AFAICT there's no noticeable
> change before/after the patch series: lsusb and dmesg output are the same.
> USB is still working properly. I don't know what those PCS_USB registers
> do exactly on the qmp PHY and I don't have access to the PHY datasheet, so
> it's hard for me to tell the impact of them being initialized vs not.
> 
> [...]

Applied, thanks!

[1/2] phy: qcom-qmp-usb: initialize PCS_USB registers
      commit: 2d3465a75c9f83684d17da6807423824bf260524
[2/2] phy: qcom-qmp-usb: split PCS_USB init table for sc8280xp and sa8775p
      commit: c599dc5cca4dd6a5c664e4a8837246e68a96cb4c

Best regards,