| Message ID | 20230828152353.16529-2-athierry@redhat.com |
|---|---|
| State | Accepted |
| Commit | 2d3465a75c9f83684d17da6807423824bf260524 |
| Headers | show |
| Series | phy: qcom-qmp-usb: fix initialization of PCS_USB | expand |
On Mon, 28 Aug 2023 at 18:24, Adrien Thierry <athierry@redhat.com> wrote: > > Currently, PCS_USB registers that have their initialization data in a > pcs_usb_tbl table are never initialized. Fix that. > > Fixes: fc64623637da ("phy: qcom-qmp-combo,usb: add support for separate PCS_USB region") > Signed-off-by: Adrien Thierry <athierry@redhat.com> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 4 ++++ > 1 file changed, 4 insertions(+)
On 28.08.2023 17:44, Dmitry Baryshkov wrote: > On Mon, 28 Aug 2023 at 18:24, Adrien Thierry <athierry@redhat.com> wrote: >> >> Currently, PCS_USB registers that have their initialization data in a >> pcs_usb_tbl table are never initialized. Fix that. >> >> Fixes: fc64623637da ("phy: qcom-qmp-combo,usb: add support for separate PCS_USB region") >> Signed-off-by: Adrien Thierry <athierry@redhat.com> > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> I noticed the same is missing in the combo phy driver! Konrad
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c index 466f0a56c82e..f9cb60f12575 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c @@ -2233,6 +2233,7 @@ static int qmp_usb_power_on(struct phy *phy) void __iomem *tx = qmp->tx; void __iomem *rx = qmp->rx; void __iomem *pcs = qmp->pcs; + void __iomem *pcs_usb = qmp->pcs_usb; void __iomem *status; unsigned int val; int ret; @@ -2256,6 +2257,9 @@ static int qmp_usb_power_on(struct phy *phy) qmp_usb_configure(pcs, cfg->pcs_tbl, cfg->pcs_tbl_num); + if (pcs_usb) + qmp_usb_configure(pcs_usb, cfg->pcs_usb_tbl, cfg->pcs_usb_tbl_num); + if (cfg->has_pwrdn_delay) usleep_range(10, 20);
Currently, PCS_USB registers that have their initialization data in a pcs_usb_tbl table are never initialized. Fix that. Fixes: fc64623637da ("phy: qcom-qmp-combo,usb: add support for separate PCS_USB region") Signed-off-by: Adrien Thierry <athierry@redhat.com> --- drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 4 ++++ 1 file changed, 4 insertions(+)