[v2,0/3] gov_power_allocator: Allow binding before cooling devices

Message

Nikita Travkin via B4 Relay April 3, 2024, 11:31 a.m. UTC

Recent changes in IPA made it fail probing if the TZ has no cooling
devices attached on probe or no trip points defined.

This series restores prior behavior to:

- allow IPA to probe before cooling devices have attached;
- allow IPA to probe when the TZ has no passive/active trip points.

I've noticed that all thermal zones fail probing with -EINVAL on my
sc7180 based Acer Aspire 1 since 6.8. This series allows me to bring
them back.

Additionally there is a commit that supresses the "sustainable_power
will be estimated" warning on TZ that have no trip points (and thus IPA
will not be able to do anything for them anyway). This allowed me to
notice that some of the TZ with cooling_devices on my platform actually
lack the sustainable_power value.

Signed-off-by: Nikita Travkin <[e-mail]>
---
Changes in v2:
- Split to two changes (Lukasz)
- Return 0 in allocate_actors_buffer() instead of suppressing -EINVAL
  (Lukasz)
- Add a change to supress "sustainable_power will be estimated" warning
  on "empty" TZ
- Link to v1: https://lore.kernel.org/r/[e-mail]

---
Nikita Travkin (3):
      thermal: gov_power_allocator: Allow binding without cooling devices
      thermal: gov_power_allocator: Allow binding without trip points
      thermal: gov_power_allocator: Suppress sustainable_power warning without trip_points

 drivers/thermal/gov_power_allocator.c | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)
---
base-commit: 727900b675b749c40ba1f6669c7ae5eb7eb8e837
change-id: 20240321-gpa-no-cooling-devs-c79ee3288325

Best regards,

Comments

Leonard Lausen April 9, 2024, 2:41 p.m. UTC | #1

Hi Nikita, Hi Łukasz,

thank you for fixing the e83747c2f8e3 ("thermal: gov_power_allocator: Set up trip points earlier") and 912e97c67cc3 ("thermal: gov_power_allocator: Move memory allocation out of throttle()") regressions as part of v6.9-rc3. As the regression was introduced in v6.8, would it be possible to include the fix in a v6.8 patch release?

Thank you
Leonard

#regzbot introduced: 912e97c67cc3f333c4c5df8f51498c651792e658
#regzbot fixed-by: 1057c4c36ef8b236a2e28edef301da0801338c5f


#regzbot introduced: e83747c2f8e3cc5e284e37a8921099f1901d79d8
#regzbot fixed-by: da781936e7c301e6197eb6513775748e79fb2575

On 4/3/24 07:31, Nikita Travkin via B4 Relay wrote:
> Recent changes in IPA made it fail probing if the TZ has no cooling
> devices attached on probe or no trip points defined.
> 
> This series restores prior behavior to:
> 
> - allow IPA to probe before cooling devices have attached;
> - allow IPA to probe when the TZ has no passive/active trip points.
> 
> I've noticed that all thermal zones fail probing with -EINVAL on my
> sc7180 based Acer Aspire 1 since 6.8. This series allows me to bring
> them back.
> 
> Additionally there is a commit that supresses the "sustainable_power
> will be estimated" warning on TZ that have no trip points (and thus IPA
> will not be able to do anything for them anyway). This allowed me to
> notice that some of the TZ with cooling_devices on my platform actually
> lack the sustainable_power value.
> 
> Signed-off-by: Nikita Travkin <[e-mail]>
> ---
> Changes in v2:
> - Split to two changes (Lukasz)
> - Return 0 in allocate_actors_buffer() instead of suppressing -EINVAL
>   (Lukasz)
> - Add a change to supress "sustainable_power will be estimated" warning
>   on "empty" TZ
> - Link to v1: https://lore.kernel.org/r/[e-mail]
> 
> ---
> Nikita Travkin (3):
>       thermal: gov_power_allocator: Allow binding without cooling devices
>       thermal: gov_power_allocator: Allow binding without trip points
>       thermal: gov_power_allocator: Suppress sustainable_power warning without trip_points
> 
>  drivers/thermal/gov_power_allocator.c | 16 ++++++----------
>  1 file changed, 6 insertions(+), 10 deletions(-)
> ---
> base-commit: 727900b675b749c40ba1f6669c7ae5eb7eb8e837
> change-id: 20240321-gpa-no-cooling-devs-c79ee3288325
> 
> Best regards,

Leonard Lausen April 9, 2024, 2:42 p.m. UTC | #2

Hi Nikita, Hi Łukasz,

thank you for fixing the e83747c2f8e3 ("thermal: gov_power_allocator: Set up trip points earlier") and 912e97c67cc3 ("thermal: gov_power_allocator: Move memory allocation out of throttle()") regressions as part of v6.9-rc3. As the regression was introduced in v6.8, would it be possible to include the fix in a v6.8 patch release?

Thank you
Leonard

(Resending with [e-mail] in CC)

#regzbot introduced: 912e97c67cc3f333c4c5df8f51498c651792e658
#regzbot fixed-by: 1057c4c36ef8b236a2e28edef301da0801338c5f


#regzbot introduced: e83747c2f8e3cc5e284e37a8921099f1901d79d8
#regzbot fixed-by: da781936e7c301e6197eb6513775748e79fb2575

On 4/3/24 07:31, Nikita Travkin via B4 Relay wrote:
> Recent changes in IPA made it fail probing if the TZ has no cooling
> devices attached on probe or no trip points defined.
> 
> This series restores prior behavior to:
> 
> - allow IPA to probe before cooling devices have attached;
> - allow IPA to probe when the TZ has no passive/active trip points.
> 
> I've noticed that all thermal zones fail probing with -EINVAL on my
> sc7180 based Acer Aspire 1 since 6.8. This series allows me to bring
> them back.
> 
> Additionally there is a commit that supresses the "sustainable_power
> will be estimated" warning on TZ that have no trip points (and thus IPA
> will not be able to do anything for them anyway). This allowed me to
> notice that some of the TZ with cooling_devices on my platform actually
> lack the sustainable_power value.
> 
> Signed-off-by: Nikita Travkin <[e-mail]>
> ---
> Changes in v2:
> - Split to two changes (Lukasz)
> - Return 0 in allocate_actors_buffer() instead of suppressing -EINVAL
>   (Lukasz)
> - Add a change to supress "sustainable_power will be estimated" warning
>   on "empty" TZ
> - Link to v1: https://lore.kernel.org/r/[e-mail]
> 
> ---
> Nikita Travkin (3):
>       thermal: gov_power_allocator: Allow binding without cooling devices
>       thermal: gov_power_allocator: Allow binding without trip points
>       thermal: gov_power_allocator: Suppress sustainable_power warning without trip_points
> 
>  drivers/thermal/gov_power_allocator.c | 16 ++++++----------
>  1 file changed, 6 insertions(+), 10 deletions(-)
> ---
> base-commit: 727900b675b749c40ba1f6669c7ae5eb7eb8e837
> change-id: 20240321-gpa-no-cooling-devs-c79ee3288325
> 
> Best regards,

Nikita Travkin April 9, 2024, 2:46 p.m. UTC | #3

вт, 9 апр. 2024 г. в 19:42, Leonard Lausen <[e-mail]>:
>
> Hi Nikita, Hi Łukasz,
>
> thank you for fixing the e83747c2f8e3 ("thermal: gov_power_allocator: Set up trip points earlier") and 912e97c67cc3 ("thermal: gov_power_allocator: Move memory allocation out of throttle()") regressions as part of v6.9-rc3. As the regression was introduced in v6.8, would it be possible to include the fix in a v6.8 patch release?
>

Hi! I think these both have already been picked for stable:

https://lore.kernel.org/r/[e-mail]
https://lore.kernel.org/r/[e-mail]/

Nikita

> Thank you
> Leonard
>
> (Resending with [e-mail] in CC)
>
> #regzbot introduced: 912e97c67cc3f333c4c5df8f51498c651792e658
> #regzbot fixed-by: 1057c4c36ef8b236a2e28edef301da0801338c5f
>
>
> #regzbot introduced: e83747c2f8e3cc5e284e37a8921099f1901d79d8
> #regzbot fixed-by: da781936e7c301e6197eb6513775748e79fb2575
>
> On 4/3/24 07:31, Nikita Travkin via B4 Relay wrote:
> > Recent changes in IPA made it fail probing if the TZ has no cooling
> > devices attached on probe or no trip points defined.
> >
> > This series restores prior behavior to:
> >
> > - allow IPA to probe before cooling devices have attached;
> > - allow IPA to probe when the TZ has no passive/active trip points.
> >
> > I've noticed that all thermal zones fail probing with -EINVAL on my
> > sc7180 based Acer Aspire 1 since 6.8. This series allows me to bring
> > them back.
> >
> > Additionally there is a commit that supresses the "sustainable_power
> > will be estimated" warning on TZ that have no trip points (and thus IPA
> > will not be able to do anything for them anyway). This allowed me to
> > notice that some of the TZ with cooling_devices on my platform actually
> > lack the sustainable_power value.
> >
> > Signed-off-by: Nikita Travkin <[e-mail]>
> > ---
> > Changes in v2:
> > - Split to two changes (Lukasz)
> > - Return 0 in allocate_actors_buffer() instead of suppressing -EINVAL
> >   (Lukasz)
> > - Add a change to supress "sustainable_power will be estimated" warning
> >   on "empty" TZ
> > - Link to v1: https://lore.kernel.org/r/[e-mail]
> >
> > ---
> > Nikita Travkin (3):
> >       thermal: gov_power_allocator: Allow binding without cooling devices
> >       thermal: gov_power_allocator: Allow binding without trip points
> >       thermal: gov_power_allocator: Suppress sustainable_power warning without trip_points
> >
> >  drivers/thermal/gov_power_allocator.c | 16 ++++++----------
> >  1 file changed, 6 insertions(+), 10 deletions(-)
> > ---
> > base-commit: 727900b675b749c40ba1f6669c7ae5eb7eb8e837
> > change-id: 20240321-gpa-no-cooling-devs-c79ee3288325
> >
> > Best regards,

Lukasz Luba April 11, 2024, 6:38 a.m. UTC | #4

On 4/9/24 15:46, Nikita Travkin wrote:
> вт, 9 апр. 2024 г. в 19:42, Leonard Lausen <[e-mail]>:
>>
>> Hi Nikita, Hi Łukasz,
>>
>> thank you for fixing the e83747c2f8e3 ("thermal: gov_power_allocator: Set up trip points earlier") and 912e97c67cc3 ("thermal: gov_power_allocator: Move memory allocation out of throttle()") regressions as part of v6.9-rc3. As the regression was introduced in v6.8, would it be possible to include the fix in a v6.8 patch release?
>>
> 
> Hi! I think these both have already been picked for stable:
> 
> https://lore.kernel.org/r/[e-mail]
> https://lore.kernel.org/r/[e-mail]/
> 

Correct