| Message ID | 20191101190705.13393-1-jeff.dagenais@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [1/7] power: supply: sbs-battery: use octal permissions on module param | expand |
Hi, On Fri, Nov 01, 2019 at 03:06:59PM -0400, Jean-Francois Dagenais wrote: > Symbolic permissions 'S_IRUSR | S_IRGRP | S_IROTH' are not > preferred. Use octal permissions '0444'. > > Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com> > --- Thanks, queued. -- Sebastian > drivers/power/supply/sbs-battery.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/supply/sbs-battery.c b/drivers/power/supply/sbs-battery.c > index 048d205d7074..0e66968dabc3 100644 > --- a/drivers/power/supply/sbs-battery.c > +++ b/drivers/power/supply/sbs-battery.c > @@ -994,6 +994,6 @@ module_i2c_driver(sbs_battery_driver); > MODULE_DESCRIPTION("SBS battery monitor driver"); > MODULE_LICENSE("GPL"); > > -module_param(force_load, bool, S_IRUSR | S_IRGRP | S_IROTH); > +module_param(force_load, bool, 0444); > MODULE_PARM_DESC(force_load, > "Attempt to load the driver even if no battery is connected"); > -- > 2.23.0 >
diff --git a/drivers/power/supply/sbs-battery.c b/drivers/power/supply/sbs-battery.c index 048d205d7074..0e66968dabc3 100644 --- a/drivers/power/supply/sbs-battery.c +++ b/drivers/power/supply/sbs-battery.c @@ -994,6 +994,6 @@ module_i2c_driver(sbs_battery_driver); MODULE_DESCRIPTION("SBS battery monitor driver"); MODULE_LICENSE("GPL"); -module_param(force_load, bool, S_IRUSR | S_IRGRP | S_IROTH); +module_param(force_load, bool, 0444); MODULE_PARM_DESC(force_load, "Attempt to load the driver even if no battery is connected");
Symbolic permissions 'S_IRUSR | S_IRGRP | S_IROTH' are not preferred. Use octal permissions '0444'. Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com> --- drivers/power/supply/sbs-battery.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)