| Message ID | 1589982799-28728-1-git-send-email-liweihang@huawei.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | RDMA/hns: Cleanups for 5.8 | expand |
On Wed, May 20, 2020 at 09:53:10PM +0800, Weihang Li wrote: > These are some cleanups, include removing dead code, modifying > varibles/fields types, and optimizing some functions. > > Lang Cheng (3): > RDMA/hns: Let software PI/CI grow naturally > RDMA/hns: Add CQ flag instead of independent enable flag > RDMA/hns: Optimize post and poll process > > Weihang Li (2): > RDMA/hns: Change all page_shift to unsigned > RDMA/hns: Change variables representing quantity to unsigned > > Xi Wang (3): > RDMA/hns: Rename QP buffer related function > RDMA/hns: Refactor the QP context filling process related to WQE > buffer configure > RDMA/hns: Optimize the usage of MTR > > Yangyang Li (1): > RDMA/hns: Remove unused code about assert I'm going to take these anyhow, the field macros could be improved someday if someone wanted. Applied to for-next I have to say the patches coming lately from hns have been following the kernel style and protocols much better. I'm also having a much easier time understanding the commit message and what the patch is trying to do. Keep it up! Thanks, Jason
On Mon, May 25, 2020 at 02:11:16PM -0300, Jason Gunthorpe wrote: > On Wed, May 20, 2020 at 09:53:10PM +0800, Weihang Li wrote: > > These are some cleanups, include removing dead code, modifying > > varibles/fields types, and optimizing some functions. > > > > Lang Cheng (3): > > RDMA/hns: Let software PI/CI grow naturally > > RDMA/hns: Add CQ flag instead of independent enable flag > > RDMA/hns: Optimize post and poll process > > > > Weihang Li (2): > > RDMA/hns: Change all page_shift to unsigned > > RDMA/hns: Change variables representing quantity to unsigned > > > > Xi Wang (3): > > RDMA/hns: Rename QP buffer related function > > RDMA/hns: Refactor the QP context filling process related to WQE > > buffer configure > > RDMA/hns: Optimize the usage of MTR > > > > Yangyang Li (1): > > RDMA/hns: Remove unused code about assert > > I'm going to take these anyhow, the field macros could be improved > someday if someone wanted. Applied to for-next > > I have to say the patches coming lately from hns have been following > the kernel style and protocols much better. I'm also having a much > easier time understanding the commit message and what the patch is > trying to do. Keep it up! +1, I have same feeling. Thanks > > Thanks, > Jason
On 2020/5/26 1:36, Leon Romanovsky wrote: > On Mon, May 25, 2020 at 02:11:16PM -0300, Jason Gunthorpe wrote: >> On Wed, May 20, 2020 at 09:53:10PM +0800, Weihang Li wrote: >>> These are some cleanups, include removing dead code, modifying >>> varibles/fields types, and optimizing some functions. >>> >>> Lang Cheng (3): >>> RDMA/hns: Let software PI/CI grow naturally >>> RDMA/hns: Add CQ flag instead of independent enable flag >>> RDMA/hns: Optimize post and poll process >>> >>> Weihang Li (2): >>> RDMA/hns: Change all page_shift to unsigned >>> RDMA/hns: Change variables representing quantity to unsigned >>> >>> Xi Wang (3): >>> RDMA/hns: Rename QP buffer related function >>> RDMA/hns: Refactor the QP context filling process related to WQE >>> buffer configure >>> RDMA/hns: Optimize the usage of MTR >>> >>> Yangyang Li (1): >>> RDMA/hns: Remove unused code about assert >> >> I'm going to take these anyhow, the field macros could be improved >> someday if someone wanted. Applied to for-next >> >> I have to say the patches coming lately from hns have been following >> the kernel style and protocols much better. I'm also having a much >> easier time understanding the commit message and what the patch is >> trying to do. Keep it up! > > +1, I have same feeling. > > Thanks > >> >> Thanks, >> Jason > Thanks for the encouragement and all your helpful suggestions. We will do our best to make it better :) Weihang
These are some cleanups, include removing dead code, modifying varibles/fields types, and optimizing some functions. Lang Cheng (3): RDMA/hns: Let software PI/CI grow naturally RDMA/hns: Add CQ flag instead of independent enable flag RDMA/hns: Optimize post and poll process Weihang Li (2): RDMA/hns: Change all page_shift to unsigned RDMA/hns: Change variables representing quantity to unsigned Xi Wang (3): RDMA/hns: Rename QP buffer related function RDMA/hns: Refactor the QP context filling process related to WQE buffer configure RDMA/hns: Optimize the usage of MTR Yangyang Li (1): RDMA/hns: Remove unused code about assert drivers/infiniband/hw/hns/hns_roce_alloc.c | 2 +- drivers/infiniband/hw/hns/hns_roce_common.h | 4 - drivers/infiniband/hw/hns/hns_roce_cq.c | 10 +- drivers/infiniband/hw/hns/hns_roce_device.h | 38 ++-- drivers/infiniband/hw/hns/hns_roce_hem.c | 2 +- drivers/infiniband/hw/hns/hns_roce_hem.h | 2 +- drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 323 +++++++++++++++------------- drivers/infiniband/hw/hns/hns_roce_main.c | 1 - drivers/infiniband/hw/hns/hns_roce_mr.c | 72 ++++--- drivers/infiniband/hw/hns/hns_roce_qp.c | 8 +- 10 files changed, 249 insertions(+), 213 deletions(-)