[for-next,0/2] : Broadcom's driver update

Message

Devesh Sharma May 26, 2020, 5:20 a.m. UTC

This series is mainly focused on adding driver fast path
changes to support variable sized wqe support. There are
two patches.

The first patch is a big patch and contain core changes to
support the feature. Since the change is related to fast
path, the patch is not splitted into multiple patches.
We want to push all related changes in one go.

The second patch is relatively few lines and changes the
ABI.

The corresponding library changes will follow short after
this patch series.

Devesh Sharma (2):
  RDMA/bnxt_re: change sq and rq to be indexed with 16B stride
  RDMA/bnxt_re: update ABI to pass wqe-mode to user space

 drivers/infiniband/hw/bnxt_re/ib_verbs.c  | 152 ++++--
 drivers/infiniband/hw/bnxt_re/ib_verbs.h  |   8 +-
 drivers/infiniband/hw/bnxt_re/main.c      |  23 +-
 drivers/infiniband/hw/bnxt_re/qplib_fp.c  | 746 +++++++++++++++++-------------
 drivers/infiniband/hw/bnxt_re/qplib_fp.h  | 128 ++++-
 drivers/infiniband/hw/bnxt_re/qplib_res.h |  63 ++-
 drivers/infiniband/hw/bnxt_re/qplib_sp.c  |  13 +-
 drivers/infiniband/hw/bnxt_re/roce_hsi.h  |   1 +
 include/uapi/rdma/bnxt_re-abi.h           |   5 +-
 9 files changed, 746 insertions(+), 393 deletions(-)

Comments

Leon Romanovsky May 26, 2020, 6:03 a.m. UTC | #1

On Tue, May 26, 2020 at 01:20:00AM -0400, Devesh Sharma wrote:
> This series is mainly focused on adding driver fast path
> changes to support variable sized wqe support. There are
> two patches.
>
> The first patch is a big patch and contain core changes to
> support the feature. Since the change is related to fast
> path, the patch is not splitted into multiple patches.
> We want to push all related changes in one go.

It doesn't sound like a solid justification for the huge patch.
All patches in series are applied together, why is it different
for this specific feature?

Thanks

Jason Gunthorpe May 26, 2020, 7:31 p.m. UTC | #2

On Tue, May 26, 2020 at 01:20:00AM -0400, Devesh Sharma wrote:
> This series is mainly focused on adding driver fast path
> changes to support variable sized wqe support. There are
> two patches.
> 
> The first patch is a big patch and contain core changes to
> support the feature. Since the change is related to fast
> path, the patch is not splitted into multiple patches.
> We want to push all related changes in one go.

That makes no sense, everyone else splits their patches.

> The second patch is relatively few lines and changes the
> ABI.
> 
> The corresponding library changes will follow short after
> this patch series.

You have to open a PR on rdma-core before any uapi changes should be
merged.

Jason

Devesh Sharma May 27, 2020, 5:36 a.m. UTC | #3

On Wed, May 27, 2020 at 1:01 AM Jason Gunthorpe <[e-mail]> wrote:
>
> On Tue, May 26, 2020 at 01:20:00AM -0400, Devesh Sharma wrote:
> > This series is mainly focused on adding driver fast path
> > changes to support variable sized wqe support. There are
> > two patches.
> >
> > The first patch is a big patch and contain core changes to
> > support the feature. Since the change is related to fast
> > path, the patch is not splitted into multiple patches.
> > We want to push all related changes in one go.
>
> That makes no sense, everyone else splits their patches.
I agree with both you and Leon about the size of the patch and there
is a guideline of sending smaller patches. I will have to see which
all parts I can split and re-send. I was not sure about the
functionality of the driver wrt each patch which comes out as a result
of split. These changes are quite closely woven. I will try though and
send a V2. Thanks
>
> > The second patch is relatively few lines and changes the
> > ABI.
> >
> > The corresponding library changes will follow short after
> > this patch series.
>
> You have to open a PR on rdma-core before any uapi changes should be
> merged.
Yeah sure, I will open that.
>
> Jason