| Message ID | 1617783353-48249-1-git-send-email-liweihang@huawei.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | RDMA/core: Correct some coding-style issues | expand |
On Wed, Apr 07, 2021 at 04:15:46PM +0800, Weihang Li wrote: > Do some cleanups according to the coding-style of kernel. > > Changes since v1: > - Remove a BUG_ON in #3 and put the changes into a new patch. > - Drop the parts about spaces around xx_for_each_xx() from #4 because some > clang formatter prefer current style. > - Link: https://patchwork.kernel.org/project/linux-rdma/cover/1617697184-48683-1-git-send-email-liweihang@huawei.com/ > > Weihang Li (1): > RDMA/core: Remove redundant BUG_ON > > Wenpeng Liang (6): > RDMA/core: Print the function name by __func__ instead of an fixed > string > RDMA/core: Remove the redundant return statements > RDMA/core: Add necessary spaces > RDMA/core: Remove redundant spaces > RDMA/core: Correct format of braces > RDMA/core: Correct format of block comments > Thanks, Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
On Wed, Apr 07, 2021 at 04:15:46PM +0800, Weihang Li wrote: > Do some cleanups according to the coding-style of kernel. > > Changes since v1: > - Remove a BUG_ON in #3 and put the changes into a new patch. > - Drop the parts about spaces around xx_for_each_xx() from #4 because some > clang formatter prefer current style. > - Link: https://patchwork.kernel.org/project/linux-rdma/cover/1617697184-48683-1-git-send-email-liweihang@huawei.com/ Let's not make a habit of sending patches like this, but I will take this one > Wenpeng Liang (6): > RDMA/core: Print the function name by __func__ instead of an fixed > string > RDMA/core: Remove the redundant return statements > RDMA/core: Add necessary spaces > RDMA/core: Remove redundant spaces I fixed the layout of most of the lines this patch touched as they were still not close enough to the canonical format. Applied to for-next, thanks Jason
On 2021/4/13 2:00, Jason Gunthorpe wrote: > On Wed, Apr 07, 2021 at 04:15:46PM +0800, Weihang Li wrote: >> Do some cleanups according to the coding-style of kernel. >> >> Changes since v1: >> - Remove a BUG_ON in #3 and put the changes into a new patch. >> - Drop the parts about spaces around xx_for_each_xx() from #4 because some >> clang formatter prefer current style. >> - Link: https://patchwork.kernel.org/project/linux-rdma/cover/1617697184-48683-1-git-send-email-liweihang@huawei.com/ > > Let's not make a habit of sending patches like this, but I will take > this one > Sure. >> Wenpeng Liang (6): >> RDMA/core: Print the function name by __func__ instead of an fixed >> string >> RDMA/core: Remove the redundant return statements >> RDMA/core: Add necessary spaces >> RDMA/core: Remove redundant spaces > > I fixed the layout of most of the lines this patch touched as they > were still not close enough to the canonical format. > OK, thank you. Weihang > Applied to for-next, thanks > > Jason >
Do some cleanups according to the coding-style of kernel. Changes since v1: - Remove a BUG_ON in #3 and put the changes into a new patch. - Drop the parts about spaces around xx_for_each_xx() from #4 because some clang formatter prefer current style. - Link: https://patchwork.kernel.org/project/linux-rdma/cover/1617697184-48683-1-git-send-email-liweihang@huawei.com/ Weihang Li (1): RDMA/core: Remove redundant BUG_ON Wenpeng Liang (6): RDMA/core: Print the function name by __func__ instead of an fixed string RDMA/core: Remove the redundant return statements RDMA/core: Add necessary spaces RDMA/core: Remove redundant spaces RDMA/core: Correct format of braces RDMA/core: Correct format of block comments drivers/infiniband/core/cache.c | 3 ++- drivers/infiniband/core/cm.c | 39 ++++++++++++++++---------------- drivers/infiniband/core/cm_msgs.h | 4 ++-- drivers/infiniband/core/cma.c | 21 ++++++++++-------- drivers/infiniband/core/iwcm.c | 1 - drivers/infiniband/core/iwpm_msg.c | 3 ++- drivers/infiniband/core/mad.c | 43 ++++++++++++++++-------------------- drivers/infiniband/core/mad_rmpp.c | 10 ++++----- drivers/infiniband/core/sysfs.c | 13 +++++------ drivers/infiniband/core/ucma.c | 8 +++---- drivers/infiniband/core/umem.c | 4 ++-- drivers/infiniband/core/user_mad.c | 30 +++++++++++-------------- drivers/infiniband/core/uverbs_cmd.c | 22 +++++++++--------- drivers/infiniband/core/verbs.c | 3 ++- 14 files changed, 98 insertions(+), 106 deletions(-)