mbox series

[v3,for-next,0/6] RDMA/bnxt_re: driver update for supporting low latency push

Message ID 1684141610-17588-1-git-send-email-selvin.xavier@broadcom.com (mailing list archive)
Headers show
Series RDMA/bnxt_re: driver update for supporting low latency push | expand

Message

Selvin Xavier May 15, 2023, 9:06 a.m. UTC
The series aims to add support for Low latency push path in
some of the bnxt devices. The low latency implementation is
supported only for the user applications. Also, the code
is modified to use  common mmap helper functions exported
by IB core. 

User library changes are getting submitted in the pull request
https://github.com/linux-rdma/rdma-core/pull/1321

Please review.

Thanks,
Selvin Xavier

v2-> v3:
  - Rebasing after the merge window
  - Fix the return value check in bnxt_re_hwrm_qcfg

v1 - v2:
  - Fixes the review comments from Leon and Jason
  - As suggested by Jason, implements the new uapi
    driver definitions for allocating pages in the
    driver and return the cookie for mmap

Selvin Xavier (6):
  RDMA/bnxt_re: Use the common mmap helper functions
  RDMA/bnxt_re: Add disassociate ucontext support
  RDMA/bnxt_re: Query function capabilities from firmware
  RDMA/bnxt_re: Move the interface version to chip context structure
  RDMA/bnxt_re: Reorg the bar mapping
  RDMA/bnxt_re: Enable low latency push

 drivers/infiniband/hw/bnxt_re/bnxt_re.h    |   3 +
 drivers/infiniband/hw/bnxt_re/ib_verbs.c   | 265 ++++++++++++++++++++++++++---
 drivers/infiniband/hw/bnxt_re/ib_verbs.h   |  19 +++
 drivers/infiniband/hw/bnxt_re/main.c       | 117 ++++++++++++-
 drivers/infiniband/hw/bnxt_re/qplib_fp.c   |   4 +-
 drivers/infiniband/hw/bnxt_re/qplib_rcfw.c |   2 +-
 drivers/infiniband/hw/bnxt_re/qplib_rcfw.h |   1 +
 drivers/infiniband/hw/bnxt_re/qplib_res.c  | 177 ++++++++++++-------
 drivers/infiniband/hw/bnxt_re/qplib_res.h  |  33 +++-
 drivers/infiniband/hw/bnxt_re/qplib_sp.c   |   3 +
 drivers/infiniband/hw/bnxt_re/qplib_sp.h   |   1 +
 include/uapi/rdma/bnxt_re-abi.h            |  32 ++++
 12 files changed, 555 insertions(+), 102 deletions(-)

Comments

Selvin Xavier May 25, 2023, 8:13 a.m. UTC | #1
On Mon, May 15, 2023 at 2:48 PM Selvin Xavier
<selvin.xavier@broadcom.com> wrote:
>
> The series aims to add support for Low latency push path in
> some of the bnxt devices. The low latency implementation is
> supported only for the user applications. Also, the code
> is modified to use  common mmap helper functions exported
> by IB core.
>
> User library changes are getting submitted in the pull request
> https://github.com/linux-rdma/rdma-core/pull/1321
>
> Please review.
Hi Jason,Leon,
 Did you get a chance to review this series?
Also, I am facing a sparse error  in the library changes.
https://github.com/linux-rdma/rdma-core/pull/1321 . I guess it's due
to the kernel headers generated. Can you please give some suggestions
to fix the error?

Thanks,
Selvin

>
> v2-> v3:
>   - Rebasing after the merge window
>   - Fix the return value check in bnxt_re_hwrm_qcfg
>
> v1 - v2:
>   - Fixes the review comments from Leon and Jason
>   - As suggested by Jason, implements the new uapi
>     driver definitions for allocating pages in the
>     driver and return the cookie for mmap
>
> Selvin Xavier (6):
>   RDMA/bnxt_re: Use the common mmap helper functions
>   RDMA/bnxt_re: Add disassociate ucontext support
>   RDMA/bnxt_re: Query function capabilities from firmware
>   RDMA/bnxt_re: Move the interface version to chip context structure
>   RDMA/bnxt_re: Reorg the bar mapping
>   RDMA/bnxt_re: Enable low latency push
>
>  drivers/infiniband/hw/bnxt_re/bnxt_re.h    |   3 +
>  drivers/infiniband/hw/bnxt_re/ib_verbs.c   | 265 ++++++++++++++++++++++++++---
>  drivers/infiniband/hw/bnxt_re/ib_verbs.h   |  19 +++
>  drivers/infiniband/hw/bnxt_re/main.c       | 117 ++++++++++++-
>  drivers/infiniband/hw/bnxt_re/qplib_fp.c   |   4 +-
>  drivers/infiniband/hw/bnxt_re/qplib_rcfw.c |   2 +-
>  drivers/infiniband/hw/bnxt_re/qplib_rcfw.h |   1 +
>  drivers/infiniband/hw/bnxt_re/qplib_res.c  | 177 ++++++++++++-------
>  drivers/infiniband/hw/bnxt_re/qplib_res.h  |  33 +++-
>  drivers/infiniband/hw/bnxt_re/qplib_sp.c   |   3 +
>  drivers/infiniband/hw/bnxt_re/qplib_sp.h   |   1 +
>  include/uapi/rdma/bnxt_re-abi.h            |  32 ++++
>  12 files changed, 555 insertions(+), 102 deletions(-)
>
> --
> 2.5.5
>