| Message ID | 1714137160-5222-1-git-send-email-kotaranov@linux.microsoft.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | RDMA/mana_ib: Implement RNIC CQs | expand |
On Fri, 26 Apr 2024 06:12:35 -0700, Konstantin Taranov wrote: > From: Konstantin Taranov <kotaranov@microsoft.com> > > This patch series implements creation and destruction of CQs > which can be used with RC QPs. > > Patches with RC QPs will be sent in the next patch series. > > [...] Applied, thanks! [1/5] RDMA/mana_ib: create EQs for RNIC CQs https://git.kernel.org/rdma/rdma/c/e73c882f0a0149 [2/5] RDMA/mana_ib: create and destroy RNIC cqs https://git.kernel.org/rdma/rdma/c/58434159168529 [3/5] RDMA/mana_ib: introduce a helper to remove cq callbacks https://git.kernel.org/rdma/rdma/c/3e41105263d5d7 [4/5] RDMA/mana_ib: boundary check before installing cq callbacks https://git.kernel.org/rdma/rdma/c/f79edef79b6a21 [5/5] RDMA/mana_ib: implement uapi for creation of rnic cq https://git.kernel.org/rdma/rdma/c/44b607ad4cdf23 Best regards,
From: Konstantin Taranov <kotaranov@microsoft.com> This patch series implements creation and destruction of CQs which can be used with RC QPs. Patches with RC QPs will be sent in the next patch series. To create a CQ for RNIC, mana_ib requires creation of EQs within mana_ib device. An EQ of mana ethernet cannot be used. To make the implementation of create_cq cleaner, this series also introduces a helper to remove CQ callbacks. Mana ethernet and mana_ib CQs are different entities which are created in different isolation zones (ethernet vs rnic). As a result, RNIC cannot use ethenet CQs and ethernet cannot use RNIC CQs. That is why, we use existing udata request for creation of ethernet CQs. If the request has an extra flag, then we create an RNIC CQ. The kernel-level CQs will be RNIC CQs (in future patches). To preserve backward and forward compatibility with RDMA-CORE, we will make the following changes to mana provider in RDMA-CORE: The rdma-core will request RNIC CQs by default, with the proposed request format and the special flag. If the mana has installed an allocator with manadv_set_context_attr, then the rdma-core understands that this is a DPDK use-case and requests an ethernet CQ, by not setting the flag. If the user has a new RDMA-core and an old kernel, then the user can detect it as the response to create RNIC cq will not have queue id. If the user has an old RDMA-core, then the flags will be 0 and ethernet CQ will be created (as expected by the user). v1->v2: 1) removed patch that replace cqe with buf_size 2) added aditional check of queue id in the remove cb helper 3) removed buf_size from uapi request and added flags instead. It seems to be a better proposal that will not require to increase the ABI version. Konstantin Taranov (5): RDMA/mana_ib: create EQs for RNIC CQs RDMA/mana_ib: create and destroy RNIC cqs RDMA/mana_ib: introduce a helper to remove cq callbacks RDMA/mana_ib: boundary check before installing cq callbacks RDMA/mana_ib: implement uapi for creation of rnic cq drivers/infiniband/hw/mana/cq.c | 74 +++++++++++++++++++---- drivers/infiniband/hw/mana/main.c | 88 +++++++++++++++++++++++++++- drivers/infiniband/hw/mana/mana_ib.h | 34 +++++++++++ drivers/infiniband/hw/mana/qp.c | 26 ++------ include/uapi/rdma/mana-abi.h | 12 ++++ 5 files changed, 200 insertions(+), 34 deletions(-)