| Message ID | 20180920183526.13995-1-leon@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Preparation to DevX extension series | expand |
On Thu, Sep 20, 2018 at 9:35 PM, Leon Romanovsky wrote: > From: Leon Romanovsky <leonro@mellanox.com> > Set uid as part of various IB commands so that the firmware can manage > the IB object in a secured way. This series deals with FS core and commands used by the Ethernet driver > net/mlx5: Update mlx5_ifc with DEVX UID bits > net/mlx5: Set uid as part of CQ commands > net/mlx5: Set uid as part of RQ commands > net/mlx5: Set uid as part of SQ commands such as the life-cycle (create, modify, destroy) of objects like: RQ/SQ/CQ/etc -- saying IB commands is inaccurate, please be more precise > > The firmware should mark this IB object with the given uid so that it > can be used later on only by objects with the same uid. these are not IB objects, but rather Ethernet objects > > Upon DEVX flows that use this objec, the pointed object must have > the same uid as of the issuer uid command. typo - objec --> object > > When a command is issued with uid=0 it means that the issuer of the > command is trusted (i.e. kernel), in that case any pointed object > can be used regardless of its uid. > > Thanks > > net/mlx5: Set uid as part of SRQ commands > net/mlx5: Set uid as part of DCT commands > net/mlx5: Set uid as part of QP commands
On Thu, Sep 20, 2018 at 09:35:19PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky <leonro@mellanox.com> > > Changelog v0->v1: > * Update commit messages > * Split DevX series to small sub-series. > * Change static initialization from {0} to be {} > > > Set uid as part of various IB commands so that the firmware can manage > the IB object in a secured way. > > The firmware should mark this IB object with the given uid so that it > can be used later on only by objects with the same uid. > > Upon DEVX flows that use this objec, the pointed object must have > the same uid as of the issuer uid command. > > When a command is issued with uid=0 it means that the issuer of the > command is trusted (i.e. kernel), in that case any pointed object > can be used regardless of its uid. > > Thanks > > Leon Romanovsky (1): > net/mlx5: Update mlx5_ifc with DEVX UID bits > > Yishai Hadas (6): > net/mlx5: Set uid as part of CQ commands > net/mlx5: Set uid as part of QP commands > net/mlx5: Set uid as part of RQ commands > net/mlx5: Set uid as part of SQ commands > net/mlx5: Set uid as part of SRQ commands > net/mlx5: Set uid as part of DCT commands This and the next series look OK to me. Let me know when it is applied to the mlx branch Thanks, Jason
On Sat, Sep 22, 2018 at 11:02:07AM -0600, Jason Gunthorpe wrote: > On Thu, Sep 20, 2018 at 09:35:19PM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky <leonro@mellanox.com> > > > > Changelog v0->v1: > > * Update commit messages > > * Split DevX series to small sub-series. > > * Change static initialization from {0} to be {} > > > > > > Set uid as part of various IB commands so that the firmware can manage > > the IB object in a secured way. > > > > The firmware should mark this IB object with the given uid so that it > > can be used later on only by objects with the same uid. > > > > Upon DEVX flows that use this objec, the pointed object must have > > the same uid as of the issuer uid command. > > > > When a command is issued with uid=0 it means that the issuer of the > > command is trusted (i.e. kernel), in that case any pointed object > > can be used regardless of its uid. > > > > Thanks > > > > Leon Romanovsky (1): > > net/mlx5: Update mlx5_ifc with DEVX UID bits > > > > Yishai Hadas (6): > > net/mlx5: Set uid as part of CQ commands > > net/mlx5: Set uid as part of QP commands > > net/mlx5: Set uid as part of RQ commands > > net/mlx5: Set uid as part of SQ commands > > net/mlx5: Set uid as part of SRQ commands > > net/mlx5: Set uid as part of DCT commands > > This and the next series look OK to me. Let me know when it is applied > to the mlx branch Applied after fixing Or's comments (typo and extra description in last patch). bd37197554eb net/mlx5: Update mlx5_ifc with DEVX UID bits 774ea6eea290 net/mlx5: Set uid as part of DCT commands a0d8c0543189 net/mlx5: Set uid as part of SRQ commands 430ae0d5a3ce net/mlx5: Set uid as part of SQ commands d269b3afffcb net/mlx5: Set uid as part of RQ commands 4ac63ec72587 net/mlx5: Set uid as part of QP commands 9ba481e2eb3b net/mlx5: Set uid as part of CQ commands Thanks > > Thanks, > Jason
From: Leon Romanovsky <leonro@mellanox.com> Changelog v0->v1: * Update commit messages * Split DevX series to small sub-series. * Change static initialization from {0} to be {} ------- From Yishai, Set uid as part of various IB commands so that the firmware can manage the IB object in a secured way. The firmware should mark this IB object with the given uid so that it can be used later on only by objects with the same uid. Upon DEVX flows that use this objec, the pointed object must have the same uid as of the issuer uid command. When a command is issued with uid=0 it means that the issuer of the command is trusted (i.e. kernel), in that case any pointed object can be used regardless of its uid. Thanks Leon Romanovsky (1): net/mlx5: Update mlx5_ifc with DEVX UID bits Yishai Hadas (6): net/mlx5: Set uid as part of CQ commands net/mlx5: Set uid as part of QP commands net/mlx5: Set uid as part of RQ commands net/mlx5: Set uid as part of SQ commands net/mlx5: Set uid as part of SRQ commands net/mlx5: Set uid as part of DCT commands drivers/net/ethernet/mellanox/mlx5/core/cq.c | 4 + drivers/net/ethernet/mellanox/mlx5/core/qp.c | 81 +++++++++++----- drivers/net/ethernet/mellanox/mlx5/core/srq.c | 30 +++++- include/linux/mlx5/cq.h | 1 + include/linux/mlx5/driver.h | 1 + include/linux/mlx5/mlx5_ifc.h | 135 +++++++++++++++----------- include/linux/mlx5/qp.h | 1 + include/linux/mlx5/srq.h | 1 + 8 files changed, 171 insertions(+), 83 deletions(-) -- 2.14.4