mbox series

[0/6] Start to clean up struct ib_device->name

Message ID 20180920224227.9988-1-jgg@ziepe.ca (mailing list archive)
Headers show
Series Start to clean up struct ib_device->name | expand

Message

Jason Gunthorpe Sept. 20, 2018, 10:42 p.m. UTC
From: Jason Gunthorpe <jgg@mellanox.com>

This struct has two copies of the device name, and it isn't really
needed. Start converting everything to use the device core's dev_name and
dev_err/etc functions.

Starting out with a patch to make the drivers stop writing to 'name' and
following with a variety of mechanical conversions in drivers/infiniba nd.

There are other ULPs outside drivers/infiniband that will need converting
before we can drop the struct member completely, but this is a healthy start
to the process.

Jason Gunthorpe (6):
  RDMA: Fully setup the device name in ib_register_device
  RDMA/core: Use dev_err/dbg/etc instead of pr_* + ibdev->name
  RDMA/drivers: Use dev_err/dbg/etc instead of pr_* + ibdev->name
  RDMA/core: Use dev_name instead of ibdev->name
  RDMA/drivers: Use dev_name instead of ibdev->name
  RDMA/ulp: Use dev_name instead of ibdev->name

 drivers/infiniband/core/cache.c               | 46 ++++++------
 drivers/infiniband/core/cm.c                  |  2 +-
 drivers/infiniband/core/cma.c                 | 11 +--
 drivers/infiniband/core/cma_configfs.c        |  2 +-
 drivers/infiniband/core/device.c              | 74 ++++++++++---------
 drivers/infiniband/core/fmr_pool.c            |  5 +-
 drivers/infiniband/core/iwcm.c                |  2 +-
 drivers/infiniband/core/nldev.c               |  3 +-
 drivers/infiniband/core/restrack.c            |  3 +-
 drivers/infiniband/core/sa_query.c            |  2 +-
 drivers/infiniband/core/security.c            |  7 +-
 drivers/infiniband/core/sysfs.c               |  4 -
 drivers/infiniband/core/user_mad.c            |  2 +-
 drivers/infiniband/core/uverbs_main.c         |  2 +-
 drivers/infiniband/core/verbs.c               | 10 ++-
 drivers/infiniband/hw/bnxt_re/main.c          |  3 +-
 drivers/infiniband/hw/cxgb3/iwch_provider.c   |  3 +-
 drivers/infiniband/hw/cxgb4/provider.c        |  3 +-
 drivers/infiniband/hw/hfi1/init.c             |  1 -
 drivers/infiniband/hw/hfi1/verbs.c            |  4 +-
 drivers/infiniband/hw/hns/hns_roce_main.c     |  3 +-
 drivers/infiniband/hw/i40iw/i40iw_verbs.c     |  3 +-
 drivers/infiniband/hw/mlx4/main.c             |  3 +-
 drivers/infiniband/hw/mlx5/main.c             | 15 ++--
 drivers/infiniband/hw/mlx5/mlx5_ib.h          | 18 ++---
 drivers/infiniband/hw/mlx5/qp.c               | 10 ++-
 drivers/infiniband/hw/mthca/mthca_mad.c       |  5 +-
 drivers/infiniband/hw/mthca/mthca_provider.c  |  3 +-
 drivers/infiniband/hw/nes/nes_verbs.c         |  5 +-
 drivers/infiniband/hw/ocrdma/ocrdma_hw.c      |  2 +-
 drivers/infiniband/hw/ocrdma/ocrdma_main.c    |  3 +-
 drivers/infiniband/hw/ocrdma/ocrdma_stats.c   |  3 +-
 drivers/infiniband/hw/qedr/main.c             |  4 +-
 drivers/infiniband/hw/qedr/qedr.h             |  2 +-
 drivers/infiniband/hw/qib/qib_init.c          |  1 -
 drivers/infiniband/hw/qib/qib_verbs.c         |  4 +-
 drivers/infiniband/hw/usnic/usnic_ib_main.c   | 37 +++++-----
 drivers/infiniband/hw/usnic/usnic_ib_sysfs.c  |  6 +-
 drivers/infiniband/hw/usnic/usnic_ib_verbs.c  | 16 ++--
 .../infiniband/hw/vmw_pvrdma/pvrdma_main.c    |  5 +-
 drivers/infiniband/sw/rdmavt/vt.c             |  6 +-
 drivers/infiniband/sw/rxe/rxe_net.c           |  6 +-
 drivers/infiniband/sw/rxe/rxe_sysfs.c         |  2 +-
 drivers/infiniband/sw/rxe/rxe_verbs.c         |  3 +-
 drivers/infiniband/ulp/ipoib/ipoib_verbs.c    |  2 +-
 drivers/infiniband/ulp/iser/iser_verbs.c      |  9 ++-
 drivers/infiniband/ulp/isert/ib_isert.c       |  2 +-
 .../infiniband/ulp/opa_vnic/opa_vnic_vema.c   |  3 +-
 drivers/infiniband/ulp/srp/ib_srp.c           | 10 ++-
 drivers/infiniband/ulp/srpt/ib_srpt.c         | 26 ++++---
 include/rdma/ib_verbs.h                       |  6 +-
 include/rdma/rdma_vt.h                        | 18 +----
 52 files changed, 213 insertions(+), 217 deletions(-)

Comments

Jason Gunthorpe Sept. 26, 2018, 8:20 p.m. UTC | #1
On Thu, Sep 20, 2018 at 04:42:21PM -0600, Jason Gunthorpe wrote:
> From: Jason Gunthorpe <jgg@mellanox.com>
> 
> This struct has two copies of the device name, and it isn't really
> needed. Start converting everything to use the device core's dev_name and
> dev_err/etc functions.
> 
> Starting out with a patch to make the drivers stop writing to 'name' and
> following with a variety of mechanical conversions in drivers/infiniba nd.
> 
> There are other ULPs outside drivers/infiniband that will need converting
> before we can drop the struct member completely, but this is a healthy start
> to the process.
> 
> Jason Gunthorpe (6):
>   RDMA: Fully setup the device name in ib_register_device
>   RDMA/core: Use dev_err/dbg/etc instead of pr_* + ibdev->name
>   RDMA/drivers: Use dev_err/dbg/etc instead of pr_* + ibdev->name
>   RDMA/core: Use dev_name instead of ibdev->name
>   RDMA/drivers: Use dev_name instead of ibdev->name
>   RDMA/ulp: Use dev_name instead of ibdev->name

Series applied (with v1 of the first patch) to for-next thanks
everyone

Jason