mbox series

[RFC,for-next,v2,0/2] ib_umem_get extract ib_ucontext from ib_udata

Message ID 20190108115906.32632-1-shamir.rabinovitch@oracle.com (mailing list archive)
Headers show
Series ib_umem_get extract ib_ucontext from ib_udata | expand

Message

Shamir Rabinovitch Jan. 8, 2019, 11:59 a.m. UTC
Follw the RFC patch from Jason, I have added prior patch to resolve
circular dependency from the form ib_core -> ib_uverbs -> ib_core
arose from the second patch.

Both patches worked OK for me with some minimal ibv_rc_pingpong
and ib_[write|send]_bw tests.

I also tested removal of all rdma modules.

If the approach is OK I can send formal patch set for this part.

Changelog
---------
v2: Jason: move ib_umem_xxx functions from ib_core to ib_uverbs 

Shamir Rabinovitch (2):
  IB/{core,uverbs}: move ib_umem_xxx functions from ib_core to ib_uverbs
  IB/{core,hw}: ib_umem_get extract ib_ucontext from ib_udata

 drivers/infiniband/core/Makefile              |  4 ++--
 drivers/infiniband/core/umem.c                |  9 +++++--
 drivers/infiniband/core/uverbs_main.c         | 24 +++++++++++++++++++
 drivers/infiniband/hw/bnxt_re/ib_verbs.c      | 10 ++++----
 drivers/infiniband/hw/cxgb3/iwch_provider.c   |  2 +-
 drivers/infiniband/hw/cxgb4/mem.c             |  2 +-
 drivers/infiniband/hw/hns/hns_roce_cq.c       |  6 ++---
 drivers/infiniband/hw/hns/hns_roce_db.c       |  5 ++--
 drivers/infiniband/hw/hns/hns_roce_mr.c       |  4 ++--
 drivers/infiniband/hw/hns/hns_roce_qp.c       |  2 +-
 drivers/infiniband/hw/hns/hns_roce_srq.c      |  4 ++--
 drivers/infiniband/hw/i40iw/i40iw_verbs.c     |  2 +-
 drivers/infiniband/hw/mlx4/cq.c               | 12 +++++-----
 drivers/infiniband/hw/mlx4/doorbell.c         |  5 ++--
 drivers/infiniband/hw/mlx4/mlx4_ib.h          |  3 ++-
 drivers/infiniband/hw/mlx4/mr.c               | 11 +++++----
 drivers/infiniband/hw/mlx4/qp.c               |  5 ++--
 drivers/infiniband/hw/mlx4/srq.c              |  4 ++--
 drivers/infiniband/hw/mlx5/cq.c               |  7 +++---
 drivers/infiniband/hw/mlx5/devx.c             |  2 +-
 drivers/infiniband/hw/mlx5/doorbell.c         |  5 ++--
 drivers/infiniband/hw/mlx5/mlx5_ib.h          |  4 +++-
 drivers/infiniband/hw/mlx5/mr.c               | 22 ++++++++---------
 drivers/infiniband/hw/mlx5/odp.c              |  4 ++--
 drivers/infiniband/hw/mlx5/qp.c               | 24 +++++++++----------
 drivers/infiniband/hw/mlx5/srq.c              |  4 ++--
 drivers/infiniband/hw/mthca/mthca_provider.c  |  2 +-
 drivers/infiniband/hw/nes/nes_verbs.c         |  2 +-
 drivers/infiniband/hw/ocrdma/ocrdma_verbs.c   |  2 +-
 drivers/infiniband/hw/qedr/verbs.c            | 24 +++++++++----------
 drivers/infiniband/hw/vmw_pvrdma/pvrdma_cq.c  |  2 +-
 drivers/infiniband/hw/vmw_pvrdma/pvrdma_mr.c  |  2 +-
 drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c  |  4 ++--
 drivers/infiniband/hw/vmw_pvrdma/pvrdma_srq.c |  2 +-
 drivers/infiniband/sw/rdmavt/mr.c             |  2 +-
 drivers/infiniband/sw/rxe/rxe_mr.c            |  2 +-
 include/rdma/ib_umem.h                        |  5 ++--
 include/rdma/ib_verbs.h                       |  1 +
 38 files changed, 137 insertions(+), 99 deletions(-)

Comments

Jason Gunthorpe Jan. 8, 2019, 11:13 p.m. UTC | #1
On Tue, Jan 08, 2019 at 01:59:04PM +0200, Shamir Rabinovitch wrote:
> Follw the RFC patch from Jason, I have added prior patch to resolve
> circular dependency from the form ib_core -> ib_uverbs -> ib_core
> arose from the second patch.
> 
> Both patches worked OK for me with some minimal ibv_rc_pingpong
> and ib_[write|send]_bw tests.
> 
> I also tested removal of all rdma modules.
> 
> If the approach is OK I can send formal patch set for this part.

I don't see anything wrong with this - if you feel it has been tested
enough just let me know and I can apply the RFC.

Jaason