| Message ID | 20190308195515.3408-1-jgg@ziepe.ca (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fix warnings in infiniband-diags | expand |
On Fri, Mar 08, 2019 at 03:55:01PM -0400, Jason Gunthorpe wrote: > From: Jason Gunthorpe <jgg@mellanox.com> > > When running on a higher warning level the compiler throws lots of interesting > warnings out, fix a bunch of them. > > This brings infiniband-diags to a level where it build warning free with the > same warnings flags that rdma-core uses by default on latest compilers. > > This is a github PR: > > https://github.com/linux-rdma/infiniband-diags/pull/21 Merged from the github pull request. Thanks, Ira > > Jason Gunthorpe (14): > libibmad: Remove madrpc_def_timeout > ibdiags: Remove unused functions > ibdiags: Use const char when appropriate > libibmad: Use {} instead of {0} > ibdiags: Put the prototype for mlnx_ext_port_infor_err in a header > ibdiags: Make functions used in only one file static > ibdiag: Use modern C function declarations > ibdiags: Use a static inline for the empty debug > ibdiags: Remove unneeded prototype > ibdiags: Remove parameters that are always passed as their global > values > ibdiags: Rename local variables to avoid shadow > ibdiags/perfquery: Move many of the globals into a struct > ibdiags/iblinkinfo: Move guid globals to a stuct > ibdiags/ibtracert: Remove srcport parameter > > include/ibdiag_common.h | 10 +- > libibmad/include/infiniband/mad.h | 2 +- > libibmad/src/dump.c | 2 +- > libibmad/src/fields.c | 96 +++--- > libibmad/src/libibmad.map | 1 - > libibmad/src/rpc.c | 5 - > libibnetdisc/include/infiniband/ibnetdisc.h | 2 +- > libibnetdisc/src/chassis.c | 11 +- > libibnetdisc/src/ibnetdisc.c | 5 +- > libibnetdisc/src/internal.h | 3 + > libibnetdisc/src/query_smp.c | 3 - > libibnetdisc/test/testleaks.c | 4 +- > src/dump_fts.c | 88 +++--- > src/ibcacheedit.c | 2 +- > src/ibccconfig.c | 38 +-- > src/ibccquery.c | 24 +- > src/ibdiag_common.c | 41 ++- > src/iblinkinfo.c | 59 ++-- > src/ibnetdiscover.c | 70 +++-- > src/ibping.c | 2 +- > src/ibportstate.c | 13 +- > src/ibqueryerrors.c | 39 +-- > src/ibroute.c | 30 +- > src/ibsendtrap.c | 6 +- > src/ibstat.c | 14 +- > src/ibsysstat.c | 2 +- > src/ibtracert.c | 12 +- > src/mcm_rereg_test.c | 16 +- > src/perfquery.c | 317 +++++++++++--------- > src/sminfo.c | 2 +- > src/smpdump.c | 41 +-- > src/smpquery.c | 38 +-- > src/vendstat.c | 21 +- > 33 files changed, 506 insertions(+), 513 deletions(-) > > -- > 2.21.0 >
From: Jason Gunthorpe <jgg@mellanox.com> When running on a higher warning level the compiler throws lots of interesting warnings out, fix a bunch of them. This brings infiniband-diags to a level where it build warning free with the same warnings flags that rdma-core uses by default on latest compilers. This is a github PR: https://github.com/linux-rdma/infiniband-diags/pull/21 Jason Gunthorpe (14): libibmad: Remove madrpc_def_timeout ibdiags: Remove unused functions ibdiags: Use const char when appropriate libibmad: Use {} instead of {0} ibdiags: Put the prototype for mlnx_ext_port_infor_err in a header ibdiags: Make functions used in only one file static ibdiag: Use modern C function declarations ibdiags: Use a static inline for the empty debug ibdiags: Remove unneeded prototype ibdiags: Remove parameters that are always passed as their global values ibdiags: Rename local variables to avoid shadow ibdiags/perfquery: Move many of the globals into a struct ibdiags/iblinkinfo: Move guid globals to a stuct ibdiags/ibtracert: Remove srcport parameter include/ibdiag_common.h | 10 +- libibmad/include/infiniband/mad.h | 2 +- libibmad/src/dump.c | 2 +- libibmad/src/fields.c | 96 +++--- libibmad/src/libibmad.map | 1 - libibmad/src/rpc.c | 5 - libibnetdisc/include/infiniband/ibnetdisc.h | 2 +- libibnetdisc/src/chassis.c | 11 +- libibnetdisc/src/ibnetdisc.c | 5 +- libibnetdisc/src/internal.h | 3 + libibnetdisc/src/query_smp.c | 3 - libibnetdisc/test/testleaks.c | 4 +- src/dump_fts.c | 88 +++--- src/ibcacheedit.c | 2 +- src/ibccconfig.c | 38 +-- src/ibccquery.c | 24 +- src/ibdiag_common.c | 41 ++- src/iblinkinfo.c | 59 ++-- src/ibnetdiscover.c | 70 +++-- src/ibping.c | 2 +- src/ibportstate.c | 13 +- src/ibqueryerrors.c | 39 +-- src/ibroute.c | 30 +- src/ibsendtrap.c | 6 +- src/ibstat.c | 14 +- src/ibsysstat.c | 2 +- src/ibtracert.c | 12 +- src/mcm_rereg_test.c | 16 +- src/perfquery.c | 317 +++++++++++--------- src/sminfo.c | 2 +- src/smpdump.c | 41 +-- src/smpquery.c | 38 +-- src/vendstat.c | 21 +- 33 files changed, 506 insertions(+), 513 deletions(-)