mbox series

[ibdiags,00/16] More warning fixes for infiniband-diags

Message ID 20190409131133.16140-1-jgg@ziepe.ca (mailing list archive)
Headers show
Series More warning fixes for infiniband-diags | expand

Message

Jason Gunthorpe April 9, 2019, 1:11 p.m. UTC
From: Jason Gunthorpe <jgg@mellanox.com>

This brings it up almost to the level where it will pass the same CI and
static checkers as rdma-core is able to.

This is a pull request:

https://github.com/linux-rdma/infiniband-diags/pull/23

Jason Gunthorpe (16):
  ibdiags: Replace cl_ntoh with betoh
  ibdiags: Replace cl_hton with htobe
  ibdiags/ibping: Use clock_gettime instead of complib
  ibdiags: Replace ib_netXX_t with __beXX
  ibdiags: Remove IN/OUT notations
  ibdiags: Do not use optarg for process_opt
  ibdiags: Mark functions taking format strings with attribute format
  ibdiags: Remove always true test
  ibdiags: Add missing static to variables
  ibdiags: Use PRIx64 when printing uint64_t
  ibdiags: Use NULL instead of 0 in all places where it used as a
    pointer
  ibdiags: Fix reversed endian swap direction
  ibdiags: Removing unneeded casting around endian conversions
  ibdiags: Add missing endian conversions on constants
  ibdiags: Add missing ULL on large constants
  ibdiags: Add __be* annotations to types

 include/ibdiag_common.h       |  13 +-
 include/ibdiag_sa.h           |   7 +-
 libibmad/src/bm.c             |   2 +-
 libibmad/src/fields.c         |   2 +-
 libibmad/src/mad.c            |   6 +-
 libibmad/src/register.c       |   2 +-
 libibmad/src/resolve.c        |   6 +-
 libibmad/src/rpc.c            |   4 +-
 libibmad/src/sa.c             |   2 +-
 libibmad/src/serv.c           |   4 +-
 libibmad/src/vendor.c         |   4 +-
 libibnetdisc/src/chassis.c    |  56 +++----
 libibnetdisc/src/ibnetdisc.c  |   4 +-
 libibnetdisc/src/query_smp.c  |   4 +-
 libibnetdisc/test/testleaks.c |  32 ++--
 src/dump_fts.c                |  17 +--
 src/ibaddr.c                  |   9 +-
 src/ibcacheedit.c             |  41 +++--
 src/ibccconfig.c              |  13 +-
 src/ibccquery.c               |  15 +-
 src/ibdiag_common.c           |  37 +++--
 src/ibdiag_sa.c               |   4 +-
 src/iblinkinfo.c              |  11 +-
 src/ibnetdiscover.c           |  13 +-
 src/ibping.c                  |  37 +++--
 src/ibportstate.c             |  75 ++++++----
 src/ibqueryerrors.c           |  68 ++++-----
 src/ibroute.c                 |  21 ++-
 src/ibsendtrap.c              |  65 ++++----
 src/ibstat.c                  |   7 +-
 src/ibsysstat.c               |  17 +--
 src/ibtracert.c               |  29 ++--
 src/mcm_rereg_test.c          |   8 +-
 src/perfquery.c               |  43 +++---
 src/saquery.c                 | 273 +++++++++++++++++-----------------
 src/sminfo.c                  |  19 +--
 src/smpdump.c                 |  37 +++--
 src/smpquery.c                |  53 ++++---
 src/vendstat.c                |  37 +++--
 39 files changed, 549 insertions(+), 548 deletions(-)

Comments

Ira Weiny April 15, 2019, 3:55 a.m. UTC | #1
On Tue, Apr 09, 2019 at 10:11:17AM -0300, Jason Gunthorpe wrote:
> From: Jason Gunthorpe <jgg@mellanox.com>
> 
> This brings it up almost to the level where it will pass the same CI and
> static checkers as rdma-core is able to.
> 
> This is a pull request:
> 
> https://github.com/linux-rdma/infiniband-diags/pull/23

Merged

Thanks,
Ira

> 
> Jason Gunthorpe (16):
>   ibdiags: Replace cl_ntoh with betoh
>   ibdiags: Replace cl_hton with htobe
>   ibdiags/ibping: Use clock_gettime instead of complib
>   ibdiags: Replace ib_netXX_t with __beXX
>   ibdiags: Remove IN/OUT notations
>   ibdiags: Do not use optarg for process_opt
>   ibdiags: Mark functions taking format strings with attribute format
>   ibdiags: Remove always true test
>   ibdiags: Add missing static to variables
>   ibdiags: Use PRIx64 when printing uint64_t
>   ibdiags: Use NULL instead of 0 in all places where it used as a
>     pointer
>   ibdiags: Fix reversed endian swap direction
>   ibdiags: Removing unneeded casting around endian conversions
>   ibdiags: Add missing endian conversions on constants
>   ibdiags: Add missing ULL on large constants
>   ibdiags: Add __be* annotations to types
> 
>  include/ibdiag_common.h       |  13 +-
>  include/ibdiag_sa.h           |   7 +-
>  libibmad/src/bm.c             |   2 +-
>  libibmad/src/fields.c         |   2 +-
>  libibmad/src/mad.c            |   6 +-
>  libibmad/src/register.c       |   2 +-
>  libibmad/src/resolve.c        |   6 +-
>  libibmad/src/rpc.c            |   4 +-
>  libibmad/src/sa.c             |   2 +-
>  libibmad/src/serv.c           |   4 +-
>  libibmad/src/vendor.c         |   4 +-
>  libibnetdisc/src/chassis.c    |  56 +++----
>  libibnetdisc/src/ibnetdisc.c  |   4 +-
>  libibnetdisc/src/query_smp.c  |   4 +-
>  libibnetdisc/test/testleaks.c |  32 ++--
>  src/dump_fts.c                |  17 +--
>  src/ibaddr.c                  |   9 +-
>  src/ibcacheedit.c             |  41 +++--
>  src/ibccconfig.c              |  13 +-
>  src/ibccquery.c               |  15 +-
>  src/ibdiag_common.c           |  37 +++--
>  src/ibdiag_sa.c               |   4 +-
>  src/iblinkinfo.c              |  11 +-
>  src/ibnetdiscover.c           |  13 +-
>  src/ibping.c                  |  37 +++--
>  src/ibportstate.c             |  75 ++++++----
>  src/ibqueryerrors.c           |  68 ++++-----
>  src/ibroute.c                 |  21 ++-
>  src/ibsendtrap.c              |  65 ++++----
>  src/ibstat.c                  |   7 +-
>  src/ibsysstat.c               |  17 +--
>  src/ibtracert.c               |  29 ++--
>  src/mcm_rereg_test.c          |   8 +-
>  src/perfquery.c               |  43 +++---
>  src/saquery.c                 | 273 +++++++++++++++++-----------------
>  src/sminfo.c                  |  19 +--
>  src/smpdump.c                 |  37 +++--
>  src/smpquery.c                |  53 ++++---
>  src/vendstat.c                |  37 +++--
>  39 files changed, 549 insertions(+), 548 deletions(-)
> 
> -- 
> 2.21.0
>