mbox series

[rdma-core,0/4] pyverbs: General improvements

Message ID 20190429155513.30543-1-noaos@mellanox.com (mailing list archive)
Headers show
Series pyverbs: General improvements | expand

Message

Noa Osherovich April 29, 2019, 3:55 p.m. UTC
This series precedes pyverbs' traffic series with some needed changes:
- Some enums were missing.
- Modify some of the user-visible prints for a more readable output
  as well as to avoid an exception thrown when printing an
  uninitialized object.
- Tests: Coverage and performance improvements.
- Add events support.

Noa Osherovich (4):
  pyverbs: Add missing enums
  pyverbs: Changes to print-related functions
  pyverbs/tests: Improvements
  pyverbs: Add events support

 pyverbs/CMakeLists.txt       |   1 +
 pyverbs/cq.pxd               |   3 +
 pyverbs/cq.pyx               |  57 +++++++-
 pyverbs/device.pyx           |  87 +++++++++---
 pyverbs/libibverbs.pxd       |   2 +
 pyverbs/libibverbs_enums.pxd |  60 ++++++++
 pyverbs/tests/base.py        |  23 +++
 pyverbs/tests/cq.py          | 168 ++++++++++------------
 pyverbs/tests/device.py      | 235 ++++++++++++++-----------------
 pyverbs/tests/mr.py          | 265 +++++++++++++++++------------------
 pyverbs/tests/pd.py          |  58 +++-----
 pyverbs/tests/utils.py       |  69 ++++++---
 12 files changed, 587 insertions(+), 441 deletions(-)
 create mode 100644 pyverbs/tests/base.py

Comments

Leon Romanovsky April 29, 2019, 6:02 p.m. UTC | #1
On Mon, Apr 29, 2019 at 06:55:09PM +0300, Noa Osherovich wrote:
> This series precedes pyverbs' traffic series with some needed changes:
> - Some enums were missing.
> - Modify some of the user-visible prints for a more readable output
>   as well as to avoid an exception thrown when printing an
>   uninitialized object.
> - Tests: Coverage and performance improvements.
> - Add events support.
>
> Noa Osherovich (4):
>   pyverbs: Add missing enums
>   pyverbs: Changes to print-related functions
>   pyverbs/tests: Improvements
>   pyverbs: Add events support
>

Noa,

Please remove Change-ID trash from your commit messages and refrain from
using power point style in commit messages.

Thanks
Noa Osherovich April 30, 2019, 7:51 a.m. UTC | #2
On 4/29/2019 9:02 PM, Leon Romanovsky wrote:

> Noa,
>
> Please remove Change-ID trash from your commit messages and refrain from
> using power point style in commit messages.
>
> Thanks

PR was updated, thanks.