mbox series

[net-next,v2,0/9,pull,request] 100GbE Intel Wired LAN Driver Updates 2020-04-20

Message ID 20200421080235.6515-1-jeffrey.t.kirsher@intel.com (mailing list archive)
Headers show
Series 100GbE Intel Wired LAN Driver Updates 2020-04-20 | expand

Message

Kirsher, Jeffrey T April 21, 2020, 8:02 a.m. UTC
This series contains the initial implementation of the Virtual Bus,
virtbus_device, virtbus_driver, updates to 'ice' and 'i40e' to use the new
Virtual Bus.

The primary purpose of the Virtual bus is to put devices on it and hook the
devices up to drivers.  This will allow drivers, like the RDMA drivers, to
hook up to devices via this Virtual bus.

This series currently builds against net-next tree.

Revision history:
v2: Made changes based on community feedback, like Pierre-Louis's and
    Jason's comments to update virtual bus interface.
 
The following are changes since commit 82ebc889091a488b4dd95e682b3c3b889a50713c:
  qed: use true,false for bool variables
and are available in the git repository at:
  git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue 100GbE

Dave Ertman (7):
  Implementation of Virtual Bus
  ice: Create and register virtual bus for RDMA
  ice: Complete RDMA peer registration
  ice: Support resource allocation requests
  ice: Enable event notifications
  ice: Allow reset operations
  ice: Pass through communications to VF

Shiraz Saleem (2):
  i40e: Move client header location
  i40e: Register a virtbus device to provide RDMA

 Documentation/driver-api/virtual_bus.rst      |   62 +
 MAINTAINERS                                   |    1 +
 drivers/bus/Kconfig                           |   10 +
 drivers/bus/Makefile                          |    2 +
 drivers/bus/virtual_bus.c                     |  279 ++++
 drivers/infiniband/hw/i40iw/Makefile          |    1 -
 drivers/infiniband/hw/i40iw/i40iw.h           |    2 +-
 drivers/net/ethernet/intel/Kconfig            |    2 +
 drivers/net/ethernet/intel/i40e/i40e.h        |    2 +-
 drivers/net/ethernet/intel/i40e/i40e_client.c |  133 +-
 drivers/net/ethernet/intel/ice/Makefile       |    1 +
 drivers/net/ethernet/intel/ice/ice.h          |   15 +
 .../net/ethernet/intel/ice/ice_adminq_cmd.h   |   33 +
 drivers/net/ethernet/intel/ice/ice_common.c   |  206 ++-
 drivers/net/ethernet/intel/ice/ice_common.h   |    9 +
 drivers/net/ethernet/intel/ice/ice_dcb_lib.c  |   68 +
 drivers/net/ethernet/intel/ice/ice_dcb_lib.h  |    3 +
 .../net/ethernet/intel/ice/ice_hw_autogen.h   |    1 +
 drivers/net/ethernet/intel/ice/ice_idc.c      | 1327 +++++++++++++++++
 drivers/net/ethernet/intel/ice/ice_idc_int.h  |  105 ++
 drivers/net/ethernet/intel/ice/ice_lib.c      |   50 +
 drivers/net/ethernet/intel/ice/ice_lib.h      |    4 +
 drivers/net/ethernet/intel/ice/ice_main.c     |  104 +-
 drivers/net/ethernet/intel/ice/ice_sched.c    |   69 +-
 drivers/net/ethernet/intel/ice/ice_switch.c   |   27 +
 drivers/net/ethernet/intel/ice/ice_switch.h   |    4 +
 drivers/net/ethernet/intel/ice/ice_type.h     |    4 +
 .../net/ethernet/intel/ice/ice_virtchnl_pf.c  |   59 +-
 include/linux/mod_devicetable.h               |    8 +
 .../linux/net/intel}/i40e_client.h            |   15 +
 include/linux/net/intel/iidc.h                |  337 +++++
 include/linux/virtual_bus.h                   |   53 +
 scripts/mod/devicetable-offsets.c             |    3 +
 scripts/mod/file2alias.c                      |    7 +
 34 files changed, 2942 insertions(+), 64 deletions(-)
 create mode 100644 Documentation/driver-api/virtual_bus.rst
 create mode 100644 drivers/bus/virtual_bus.c
 create mode 100644 drivers/net/ethernet/intel/ice/ice_idc.c
 create mode 100644 drivers/net/ethernet/intel/ice/ice_idc_int.h
 rename {drivers/net/ethernet/intel/i40e => include/linux/net/intel}/i40e_client.h (94%)
 create mode 100644 include/linux/net/intel/iidc.h
 create mode 100644 include/linux/virtual_bus.h

Comments

Kirsher, Jeffrey T April 21, 2020, 8:15 a.m. UTC | #1
> -----Original Message-----
> From: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>
> Sent: Tuesday, April 21, 2020 01:02
> To: davem@davemloft.net; gregkh@linuxfoundation.org
> Cc: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; netdev@vger.kernel.org;
> linux-rdma@vger.kernel.org; nhorman@redhat.com; sassmann@redhat.com;
> jgg@ziepe.ca; parav@mellanox.com; galpress@amazon.com;
> selvin.xavier@broadcom.com; sriharsha.basavapatna@broadcom.com;
> benve@cisco.com; bharat@chelsio.com; xavier.huwei@huawei.com;
> yishaih@mellanox.com; leonro@mellanox.com; mkalderon@marvell.com;
> aditr@vmware.com; ranjani.sridharan@linux.intel.com; pierre-
> louis.bossart@linux.intel.com
> Subject: [net-next v2 0/9][pull request] 100GbE Intel Wired LAN Driver Updates
> 2020-04-20
> 
> This series contains the initial implementation of the Virtual Bus, virtbus_device,
> virtbus_driver, updates to 'ice' and 'i40e' to use the new Virtual Bus.
> 
> The primary purpose of the Virtual bus is to put devices on it and hook the
> devices up to drivers.  This will allow drivers, like the RDMA drivers, to hook up
> to devices via this Virtual bus.
> 
> This series currently builds against net-next tree.
> 
> Revision history:
> v2: Made changes based on community feedback, like Pierre-Louis's and
>     Jason's comments to update virtual bus interface.
[Kirsher, Jeffrey T] 

David Miller, I know we have heard from Greg KH and Jason Gunthorpe on the patch
series and have responded accordingly, I would like your personal opinion on the
patch series.  I respect your opinion and would like to make sure we appease all the
maintainers and users involved to get this accepted into the 5.8 kernel.

> 
> The following are changes since commit
> 82ebc889091a488b4dd95e682b3c3b889a50713c:
>   qed: use true,false for bool variables and are available in the git repository at:
>   git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue 100GbE
> 
> Dave Ertman (7):
>   Implementation of Virtual Bus
>   ice: Create and register virtual bus for RDMA
>   ice: Complete RDMA peer registration
>   ice: Support resource allocation requests
>   ice: Enable event notifications
>   ice: Allow reset operations
>   ice: Pass through communications to VF
> 
> Shiraz Saleem (2):
>   i40e: Move client header location
>   i40e: Register a virtbus device to provide RDMA
> 
>  Documentation/driver-api/virtual_bus.rst      |   62 +
>  MAINTAINERS                                   |    1 +
>  drivers/bus/Kconfig                           |   10 +
>  drivers/bus/Makefile                          |    2 +
>  drivers/bus/virtual_bus.c                     |  279 ++++
>  drivers/infiniband/hw/i40iw/Makefile          |    1 -
>  drivers/infiniband/hw/i40iw/i40iw.h           |    2 +-
>  drivers/net/ethernet/intel/Kconfig            |    2 +
>  drivers/net/ethernet/intel/i40e/i40e.h        |    2 +-
>  drivers/net/ethernet/intel/i40e/i40e_client.c |  133 +-
>  drivers/net/ethernet/intel/ice/Makefile       |    1 +
>  drivers/net/ethernet/intel/ice/ice.h          |   15 +
>  .../net/ethernet/intel/ice/ice_adminq_cmd.h   |   33 +
>  drivers/net/ethernet/intel/ice/ice_common.c   |  206 ++-
>  drivers/net/ethernet/intel/ice/ice_common.h   |    9 +
>  drivers/net/ethernet/intel/ice/ice_dcb_lib.c  |   68 +
>  drivers/net/ethernet/intel/ice/ice_dcb_lib.h  |    3 +
>  .../net/ethernet/intel/ice/ice_hw_autogen.h   |    1 +
>  drivers/net/ethernet/intel/ice/ice_idc.c      | 1327 +++++++++++++++++
>  drivers/net/ethernet/intel/ice/ice_idc_int.h  |  105 ++
>  drivers/net/ethernet/intel/ice/ice_lib.c      |   50 +
>  drivers/net/ethernet/intel/ice/ice_lib.h      |    4 +
>  drivers/net/ethernet/intel/ice/ice_main.c     |  104 +-
>  drivers/net/ethernet/intel/ice/ice_sched.c    |   69 +-
>  drivers/net/ethernet/intel/ice/ice_switch.c   |   27 +
>  drivers/net/ethernet/intel/ice/ice_switch.h   |    4 +
>  drivers/net/ethernet/intel/ice/ice_type.h     |    4 +
>  .../net/ethernet/intel/ice/ice_virtchnl_pf.c  |   59 +-
>  include/linux/mod_devicetable.h               |    8 +
>  .../linux/net/intel}/i40e_client.h            |   15 +
>  include/linux/net/intel/iidc.h                |  337 +++++
>  include/linux/virtual_bus.h                   |   53 +
>  scripts/mod/devicetable-offsets.c             |    3 +
>  scripts/mod/file2alias.c                      |    7 +
>  34 files changed, 2942 insertions(+), 64 deletions(-)  create mode 100644
> Documentation/driver-api/virtual_bus.rst
>  create mode 100644 drivers/bus/virtual_bus.c  create mode 100644
> drivers/net/ethernet/intel/ice/ice_idc.c
>  create mode 100644 drivers/net/ethernet/intel/ice/ice_idc_int.h
>  rename {drivers/net/ethernet/intel/i40e => include/linux/net/intel}/i40e_client.h
> (94%)  create mode 100644 include/linux/net/intel/iidc.h  create mode 100644
> include/linux/virtual_bus.h
> 
> --
> 2.25.3
Greg KH April 21, 2020, 8:30 a.m. UTC | #2
On Tue, Apr 21, 2020 at 08:15:59AM +0000, Kirsher, Jeffrey T wrote:
> > -----Original Message-----
> > From: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>
> > Sent: Tuesday, April 21, 2020 01:02
> > To: davem@davemloft.net; gregkh@linuxfoundation.org
> > Cc: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; netdev@vger.kernel.org;
> > linux-rdma@vger.kernel.org; nhorman@redhat.com; sassmann@redhat.com;
> > jgg@ziepe.ca; parav@mellanox.com; galpress@amazon.com;
> > selvin.xavier@broadcom.com; sriharsha.basavapatna@broadcom.com;
> > benve@cisco.com; bharat@chelsio.com; xavier.huwei@huawei.com;
> > yishaih@mellanox.com; leonro@mellanox.com; mkalderon@marvell.com;
> > aditr@vmware.com; ranjani.sridharan@linux.intel.com; pierre-
> > louis.bossart@linux.intel.com
> > Subject: [net-next v2 0/9][pull request] 100GbE Intel Wired LAN Driver Updates
> > 2020-04-20
> > 
> > This series contains the initial implementation of the Virtual Bus, virtbus_device,
> > virtbus_driver, updates to 'ice' and 'i40e' to use the new Virtual Bus.
> > 
> > The primary purpose of the Virtual bus is to put devices on it and hook the
> > devices up to drivers.  This will allow drivers, like the RDMA drivers, to hook up
> > to devices via this Virtual bus.
> > 
> > This series currently builds against net-next tree.
> > 
> > Revision history:
> > v2: Made changes based on community feedback, like Pierre-Louis's and
> >     Jason's comments to update virtual bus interface.
> [Kirsher, Jeffrey T] 
> 
> David Miller, I know we have heard from Greg KH and Jason Gunthorpe on the patch
> series and have responded accordingly, I would like your personal opinion on the
> patch series.  I respect your opinion and would like to make sure we appease all the
> maintainers and users involved to get this accepted into the 5.8 kernel.

Wait, you haven't gotten my ack on that code, why are you asking for it
to be merged already???

{sigh}

greg k-h
Kirsher, Jeffrey T April 21, 2020, 8:37 a.m. UTC | #3
> -----Original Message-----
> From: gregkh@linuxfoundation.org <gregkh@linuxfoundation.org>
> Sent: Tuesday, April 21, 2020 01:30
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>
> Cc: davem@davemloft.net; netdev@vger.kernel.org; linux-
> rdma@vger.kernel.org; nhorman@redhat.com; sassmann@redhat.com;
> jgg@ziepe.ca; parav@mellanox.com; galpress@amazon.com;
> selvin.xavier@broadcom.com; sriharsha.basavapatna@broadcom.com;
> benve@cisco.com; bharat@chelsio.com; xavier.huwei@huawei.com;
> yishaih@mellanox.com; leonro@mellanox.com; mkalderon@marvell.com;
> aditr@vmware.com; ranjani.sridharan@linux.intel.com; pierre-
> louis.bossart@linux.intel.com
> Subject: Re: [net-next v2 0/9][pull request] 100GbE Intel Wired LAN Driver
> Updates 2020-04-20
> 
> On Tue, Apr 21, 2020 at 08:15:59AM +0000, Kirsher, Jeffrey T wrote:
> > > -----Original Message-----
> > > From: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>
> > > Sent: Tuesday, April 21, 2020 01:02
> > > To: davem@davemloft.net; gregkh@linuxfoundation.org
> > > Cc: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>;
> > > netdev@vger.kernel.org; linux-rdma@vger.kernel.org;
> > > nhorman@redhat.com; sassmann@redhat.com; jgg@ziepe.ca;
> > > parav@mellanox.com; galpress@amazon.com;
> selvin.xavier@broadcom.com;
> > > sriharsha.basavapatna@broadcom.com;
> > > benve@cisco.com; bharat@chelsio.com; xavier.huwei@huawei.com;
> > > yishaih@mellanox.com; leonro@mellanox.com; mkalderon@marvell.com;
> > > aditr@vmware.com; ranjani.sridharan@linux.intel.com; pierre-
> > > louis.bossart@linux.intel.com
> > > Subject: [net-next v2 0/9][pull request] 100GbE Intel Wired LAN
> > > Driver Updates
> > > 2020-04-20
> > >
> > > This series contains the initial implementation of the Virtual Bus,
> > > virtbus_device, virtbus_driver, updates to 'ice' and 'i40e' to use the new
> Virtual Bus.
> > >
> > > The primary purpose of the Virtual bus is to put devices on it and
> > > hook the devices up to drivers.  This will allow drivers, like the
> > > RDMA drivers, to hook up to devices via this Virtual bus.
> > >
> > > This series currently builds against net-next tree.
> > >
> > > Revision history:
> > > v2: Made changes based on community feedback, like Pierre-Louis's and
> > >     Jason's comments to update virtual bus interface.
> > [Kirsher, Jeffrey T]
> >
> > David Miller, I know we have heard from Greg KH and Jason Gunthorpe on
> > the patch series and have responded accordingly, I would like your
> > personal opinion on the patch series.  I respect your opinion and
> > would like to make sure we appease all the maintainers and users involved to
> get this accepted into the 5.8 kernel.
> 
> Wait, you haven't gotten my ack on that code, why are you asking for it to be
> merged already???
> 
[Kirsher, Jeffrey T] 

I was just asking for Dave's review, I was not asking that get merged without your or anyone's ACK.

> {sigh}
> 
> greg k-h
Jason Gunthorpe April 21, 2020, 12:10 p.m. UTC | #4
On Tue, Apr 21, 2020 at 01:02:26AM -0700, Jeff Kirsher wrote:
> This series contains the initial implementation of the Virtual Bus,
> virtbus_device, virtbus_driver, updates to 'ice' and 'i40e' to use the new
> Virtual Bus.
> 
> The primary purpose of the Virtual bus is to put devices on it and hook the
> devices up to drivers.  This will allow drivers, like the RDMA drivers, to
> hook up to devices via this Virtual bus.
> 
> This series currently builds against net-next tree.
> 
> Revision history:
> v2: Made changes based on community feedback, like Pierre-Louis's and
>     Jason's comments to update virtual bus interface.

A lot of stuff has been ignored, why?

Jason
David Miller April 22, 2020, 7:55 p.m. UTC | #5
From: "Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>
Date: Tue, 21 Apr 2020 08:15:59 +0000

> David Miller, I know we have heard from Greg KH and Jason Gunthorpe on the patch
> series and have responded accordingly, I would like your personal opinion on the
> patch series.  I respect your opinion and would like to make sure we appease all the
> maintainers and users involved to get this accepted into the 5.8 kernel.

No major objections from me once you properly and fully address Greg KH et al.'s
feedback.

Thanks.